Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link roads are rendered identically to normal roads #10717

Closed
Openstreetmapler opened this issue Jan 29, 2025 · 4 comments · Fixed by #10722
Closed

Link roads are rendered identically to normal roads #10717

Openstreetmapler opened this issue Jan 29, 2025 · 4 comments · Fixed by #10722
Labels
map-renderer An issue with how things are rendered in the map

Comments

@Openstreetmapler
Copy link

Openstreetmapler commented Jan 29, 2025

URL

https://www.openstreetmap.org/edit#map=18/62.413467/17.341047

How to reproduce the issue?

  1. (optional if you followed the above link) Draw two lines and choose a normal road and a link road preset for each of them respectively, i.e. one of the following combos:
    • highway=motorway and highway=motorway_link
    • highway=trunk and highway=trunk_link
    • highway=primary and highway=primary_link
    • highway=secondary and highway=secondary_link
    • highway=tertiary and highway=tertiary_link
  2. Observe: You cannot distinguish between normal and link roads without selecting them and looking at the sidebar.

Screenshot(s) or anything else?

Motorway links mapped as motorways, can easily see error on map
In openstreetmap-carto (standard style), you can easily tell highway=motorway from highway=motorway_link by their line width. In this case, the motorway links are incorrectly mapped as motorways except for the short segment in the upper part. Plus, you can guess incorrect layer=-1 tags for the motorway segments on the left because they’re rendered behind the secondary roads.

Cannot tell motorway from motorway_link in iD editor 1
Cannot tell motorway from motorway_link in iD editor 2
In iD, highway=motorway and highway=motorway_link look identical to each other (same width). This makes fixing these types of issues in the OSM road network error-prone, as you’ll likely miss a road segment while fixing the incorrect tagging!

In JOSM, the default MapPaint style doesn’t distinguish link roads from regular rendering either, but you can create or use a different style there which has the distinction – this is not possible to do in iD!

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit, Development version at ideditor.netlify.app

What version numbers does this issue effect?

2.30.4, 2.31.0-dev

Which browsers are you seeing this problem on?

Firefox

@oneanonymousdeveloper
Copy link

can you provide a short video to better understand this issue

@Openstreetmapler
Copy link
Author

can you provide a short video to better understand this issue

(You might have to download this video to watch it!)
https://github.com/user-attachments/assets/499ca29e-148b-4b32-aa3d-8b75e34cb4e0
In the video, I’m changing some of the wrongly-tagged motorways to motorway links. Notice how the rendering doesn’t change when I do that, therefore I never know at a glance which road segments I already fixed and which ones are still wrong.

@tyrasd tyrasd added the map-renderer An issue with how things are rendered in the map label Jan 31, 2025
@tyrasd tyrasd closed this as completed in 825faf0 Feb 12, 2025
@hlfan
Copy link
Contributor

hlfan commented Feb 22, 2025

@tyrasd this doesn't cover *_link roads under construction or proposed ones, thus not matching how future paths get thinner.

@Openstreetmapler
Copy link
Author

Using the awesome new version of iD, I have now fixed the issue with the motorway links.

Plus, you can guess incorrect layer=-1 tags for the motorway segments on the left because they’re rendered behind the secondary roads.

Nope, that assumption of me was incorrect – the secondary roads had layer=1 while the motorway segments didn’t have layer tags at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
map-renderer An issue with how things are rendered in the map
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants