Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiselection via search results #10715

Open
jidanni opened this issue Jan 29, 2025 · 6 comments
Open

Allow multiselection via search results #10715

jidanni opened this issue Jan 29, 2025 · 6 comments
Labels
usability An issue with ease-of-use or design

Comments

@jidanni
Copy link
Contributor

jidanni commented Jan 29, 2025

Here there could be checkboxes added on the left to each of the five items.

Image

Doing that would be a way for the user to finally multiselect all the segments of that road.

Then the user could in the Tags box at the bottom of the left panel, change some of theses items:

highway=*
name=西屯路一段
name:en=Xitun Road Section 1
name:zh=西屯路一段

Thus finally giving the user a way to update e.g., the name of a road along its entire path!

Currently one needs JOSM apparently to do that. No more!

Yes, you are wondering why can't the user just tediously SHIFT+CLICK all the many segments?

Well that is error prone, and one little clicking error and all that clicking gets unclicked and is wasted. Also itsy bitsy segments are hard to click on.

Anyway this could solve

@tyrasd tyrasd added the usability An issue with ease-of-use or design label Jan 31, 2025
@tyrasd
Copy link
Member

tyrasd commented Jan 31, 2025

I don't think the best way to implement this from a UI point of view is with checkboxes, but I do see the use cases where getting a multiselection from the search results list would be useful.

Perhaps it could work to just have a "select all" button on the bottom of the search results? Or alternatively, the shift-click pattern could also be applied on the search results list: as long as the shift key is pressed, the list remains open and additional elements can be selected (for touch-input devices, this could be implemented via long-press maybe).

@Deeptanshu-sankhwar
Copy link
Contributor

Thanks for sharing this @jidanni @tyrasd . I have raised a PR for an implementation that tries to solve the above issue. In the PR, I allow selection of multiple features from the dropdown when SHIFT key is pressed.

As you can see in the first run of the preview, I am holding SHIFT for the first three features in the dropdown and release it for the 4 feature thereby getting a selection of the selected 4 features. In the second run, I am just selecting one feature without any SHIFT key pressed.

Do let me know your thoughts about it. Thanks.

Screen.Recording.2025-02-01.at.10.20.54.AM.1.mp4

@jidanni
Copy link
Contributor Author

jidanni commented Feb 2, 2025

@Deeptanshu-sankhwar Thanks for all your hard work.

@Deeptanshu-sankhwar
Copy link
Contributor

Thanks a lot for your cheerful comments @jidanni ! Always love checking and working on the issues you post.

@jidanni
Copy link
Contributor Author

jidanni commented Feb 3, 2025

@Deeptanshu-sankhwar I can't find your email address to tell you if you really want to be a hero, you could fix https://community.openstreetmap.org/t/struggling-to-switch-to-josm/110978/54 . Thanks. But note https://community.openstreetmap.org/t/josm-wayland-how-will-it-evolve/125078/9 so just add flexibility to iD... #7866

@Deeptanshu-sankhwar
Copy link
Contributor

Thanks a lot for sharing @jidanni! I'll start looking into it.

Also, worth mentioning, I tried to reach out to you on OSM Slack, and my email is [email protected]. 😄

Hope you're having a great day so far @jidanni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability An issue with ease-of-use or design
Projects
None yet
Development

No branches or pull requests

3 participants