Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw away identical tags. Warn instead. #10714

Open
jidanni opened this issue Jan 29, 2025 · 5 comments
Open

Don't throw away identical tags. Warn instead. #10714

jidanni opened this issue Jan 29, 2025 · 5 comments
Labels
wontfix-not-a-bug Not actually a bug

Comments

@jidanni
Copy link
Contributor

jidanni commented Jan 29, 2025

Here something bad is about to happen,

Image

The user has accidentally entered two identical tags (name) and iD will silently throw away one of them.

It should warn instead.

@draunger
Copy link
Contributor

@jidanni I have also seen this problem and now starting working on that..

@bryceco
Copy link
Contributor

bryceco commented Jan 29, 2025

What’s weird is that the second tag doesn’t replace the first as soon as it is entered.

@draunger
Copy link
Contributor

draunger commented Jan 29, 2025

hey @jidanni i again reproduce this and i see that when we enter the same tag then the new tag replaces the old one . this issue is already implemented https://www.loom.com/share/47492bed5a4148899481a057b876abe6?sid=9d814d39-1370-4ba6-96be-6ee7f9602677 you can see in this video this already working

@jidanni
Copy link
Contributor Author

jidanni commented Jan 30, 2025

@draunger Yes. But let's say we didn't realize we put an identical tag (but with a different value) there.

Well, the system should warn, and demand that we choose one or the other.

That way we would learn to first delete the one we want to replace.

Instead of taking a gamble and hoping the system will read our mind and delete the right one for us.

@tyrasd
Copy link
Member

tyrasd commented Jan 31, 2025

The text-mode raw tag editor is meant to be a feature for experienced users. A warning would be annoying in that context.

What’s weird is that the second tag doesn’t replace the first as soon as it is entered.

That's odd. In my testing the newly entered tag does replace the existing value. @bryceco Do you have a way to reproduce the behaviour where the second tag does not replace the first one?

@tyrasd tyrasd added the wontfix-not-a-bug Not actually a bug label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix-not-a-bug Not actually a bug
Projects
None yet
Development

No branches or pull requests

4 participants