-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't throw away identical tags. Warn instead. #10714
Comments
@jidanni I have also seen this problem and now starting working on that.. |
What’s weird is that the second tag doesn’t replace the first as soon as it is entered. |
hey @jidanni i again reproduce this and i see that when we enter the same tag then the new tag replaces the old one . this issue is already implemented https://www.loom.com/share/47492bed5a4148899481a057b876abe6?sid=9d814d39-1370-4ba6-96be-6ee7f9602677 you can see in this video this already working |
@draunger Yes. But let's say we didn't realize we put an identical tag (but with a different value) there. Well, the system should warn, and demand that we choose one or the other. That way we would learn to first delete the one we want to replace. Instead of taking a gamble and hoping the system will read our mind and delete the right one for us. |
The text-mode raw tag editor is meant to be a feature for experienced users. A warning would be annoying in that context.
That's odd. In my testing the newly entered tag does replace the existing value. @bryceco Do you have a way to reproduce the behaviour where the second tag does not replace the first one? |
Here something bad is about to happen,
The user has accidentally entered two identical tags (
name
) and iD will silently throw away one of them.It should warn instead.
The text was updated successfully, but these errors were encountered: