Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to see what they modified before uploading #10713

Open
jidanni opened this issue Jan 29, 2025 · 7 comments
Open

Allow the user to see what they modified before uploading #10713

jidanni opened this issue Jan 29, 2025 · 7 comments
Labels
bluesky Bluesky issues are extra challenging - this might take a while or be impossible usability An issue with ease-of-use or design

Comments

@jidanni
Copy link
Contributor

jidanni commented Jan 29, 2025

Description

We forgot what we changed.
Undo and redo don't divulge what it was.
Our last chance is here,
Image
But down at the bottom clicking Modified Dam won't tell us what we changed about the dam either, because it is not a hyperlink.

Our very last chance is the osmChange file link, but it shouldn't have to come to that.

Indeed that file is very hard for new users to understand.

Anyway here to see what the user changed, the user must find on the map what they changed, and select it, and look at the bottom of the left sidepanel, and toggle undo / redo in the right upper corner of their screen, to see what changes.

It would be best to be like Vespucci, where one can review each changed item.

@oneanonymousdeveloper

This comment has been minimized.

@tyrasd tyrasd added usability An issue with ease-of-use or design bluesky Bluesky issues are extra challenging - this might take a while or be impossible labels Jan 29, 2025
@tyrasd
Copy link
Member

tyrasd commented Jan 29, 2025

It would be best to be like Vespucci,

can you please share how this is implemented in Vespucci? Maybe as a screenshot?

@jidanni
Copy link
Contributor Author

jidanni commented Jan 30, 2025

https://learnosm.org/en/mobile-mapping/vespucci/#uploading-your-changes and we can tap each item to see the details.

@tyrasd
Copy link
Member

tyrasd commented Jan 31, 2025

And what information is actually displayed when a user taps on an item to see the details?

@jidanni
Copy link
Contributor Author

jidanni commented Feb 1, 2025

Screenshot_20250201_155907_Vespucci.jpg

Screenshot_20250201_155919_Vespucci.jpg

@sun-geo
Copy link
Contributor

sun-geo commented Feb 28, 2025

Image

But down at the bottom clicking Modified Dam won't tell us what we changed about the dam either, because it is not a hyperlink.

Btw, as far as I remember, for some reason there must have been a regression (one or two years ago) for an earlier implemented function. In older versions of iD you could double click the items of changed objects in that list. After double clicking the map (on right side) was centred to this object (And the object even got the focus, so that if you canceled the upload procedure afterwards you could continue working there directly). I'm strongly missing this function. If this is back in operation, you are also be able to check easier the changed tags...
(by centre the object, and click of the blue object link at bottom left to open an new windows and look the current live tags on osm.org)

Nowadays there is an icon used for similar function for relation members:

Image

This could also be added here to the changed object list items, see:

Image

@sun-geo
Copy link
Contributor

sun-geo commented Feb 28, 2025

Update: just double checked it, the centre function seems working, but sending the focus to the centred object doesn't.

So what remains, please reactivate the send-focus-function and adding the centre icon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bluesky Bluesky issues are extra challenging - this might take a while or be impossible usability An issue with ease-of-use or design
Projects
None yet
Development

No branches or pull requests

4 participants