Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all code compatible with Smarty v3 #18

Open
strafford opened this issue Mar 1, 2019 · 1 comment
Open

Not all code compatible with Smarty v3 #18

strafford opened this issue Mar 1, 2019 · 1 comment

Comments

@strafford
Copy link

strafford commented Mar 1, 2019

I wonder if you would be open to suggestions. Trying to get this working w/ v3 of Smarty.

In the following file: "HTML/QuickForm/Renderer/ArraySmarty.php" on line 319 there is a

This is the function:
private function _tplFetch($tplSource) { if (!function_exists('smarty_function_eval')) { return ($this->_tpl->fetch("eval:$tplSource")); } return smarty_function_eval(array('var' => $tplSource), $this->_tpl); }

This could work for making it v3 compliant:
` private function _tplFetch($tplSource)
{
return ($this->_tpl->fetch("eval:$tplSource"));
}

`
(source: https://www.smarty.net/forums/viewtopic.php?p=84745)

@flack
Copy link
Collaborator

flack commented Mar 3, 2019

Hi!

I mean, in principle I'm open to pull requests, but I have to say I never used Smarty myself (I only know it by name), so I'm not really qualified to review this I think.

What exactly is the problem you're trying to fix? Because from the code you posted it looks like you only removed the function_exists check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants