Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][build] Fix CI and building of project using latest image from build-tools #284

Closed
shivanshuraj1333 opened this issue Jan 7, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@shivanshuraj1333
Copy link
Member

What happened?

The project CI is still using old image (see https://github.com/open-telemetry/opentelemetry-network/blob/main/.github/workflows/build-and-release.yaml#L39), if we try to build the project from latest image from build-tools, there are series of errors.

With some tweaks, I was able to build render_compiler but other components require protobuf, gRPC and absel bumps. Also changes in the go mod files, and re running go mod vendor.

Using protobuf 26.1.0
Using gRPC 1.65.5

there are couple of error wrt to the usage of GUARDED_BY(mu_)

eBPF Collector version

latest commit from main

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

eBPF Collector configuration

No response

Log output

some sample error logs:

[ 84%] Building CXX object reducer/CMakeFiles/reducerlib.dir/worker.cc.o
In file included from /root/src/reducer/worker.cc:4:
/root/src/reducer/worker.h:111:29: error: expected ';' at end of member declaration
  111 |   std::vector<uv_os_sock_t> tcp_sock_fds_ GUARDED_BY(mu_);
      |                             ^~~~~~~~~~~~~
      |                                          ;
compilation terminated due to -fmax-errors=1.
make[3]: *** [reducer/CMakeFiles/reducerlib.dir/build.make:121: reducer/CMakeFiles/reducerlib.dir/worker.cc.o] Error 1
make[2]: *** [CMakeFiles/Makefile2:5725: reducer/CMakeFiles/reducerlib.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:5611: reducer/CMakeFiles/reducer.dir/rule] Error 2
make: *** [Makefile:2270: reducer] Error 2
(failed reverse-i-search)`vi': ^C otlp/CMakeLists.txt
In file included from /root/src/reducer/otlp_grpc_formatter.cc:9:
/root/src/otlp/otlp_util.h: In function 'std::string get_request_json(const T&)':
/root/src/otlp/otlp_util.h:15:22: error: 'using JsonPrintOptions = struct google::protobuf::json::PrintOptions' {aka 'struct google::protobuf::json::PrintOptions'} has no member named 'always_print_primitive_fields'
   15 |   json_print_options.always_print_primitive_fields = true;
      |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[3]: *** [reducer/CMakeFiles/metrics_output.dir/build.make:121: reducer/CMakeFiles/metrics_output.dir/otlp_grpc_formatter.cc.o] Error 1
make[2]: *** [CMakeFiles/Makefile2:5759: reducer/CMakeFiles/metrics_output.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:5611: reducer/CMakeFiles/reducer.dir/rule] Error 2
make: *** [Makefile:2270: reducer] Error 2
In file included from /root/src/otlp/otlp_test_server.h:6,
                 from /root/src/otlp/otlp_grpc_client_test.cc:6:
/root/src/otlp/otlp_util.h: In function 'std::string get_request_json(const T&)':
/root/src/otlp/otlp_util.h:15:22: error: 'using JsonPrintOptions = struct google::protobuf::json::PrintOptions' {aka 'struct google::protobuf::json::PrintOptions'} has no member named 'always_print_primitive_fields'
   15 |   json_print_options.always_print_primitive_fields = true;
      |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated due to -fmax-errors=1.
make[2]: *** [otlp/CMakeFiles/otlp_grpc_client_test.dir/build.make:82: otlp/CMakeFiles/otlp_grpc_client_test.dir/otlp_grpc_client_test.cc.o] Error 1
Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.3.3/userguide/command_line_interface.html#sec:command_line_warnings

Execution optimizations have been disabled for 1 invalid unit(s) of work during this build to ensure correctness.
Please consult deprecation warnings for more details.


### Additional context

I tried to fix these issue with https://github.com/open-telemetry/opentelemetry-network/pull/283 but there were failing tests.
@shivanshuraj1333 shivanshuraj1333 added the bug Something isn't working label Jan 7, 2025
@shivanshuraj1333
Copy link
Member Author

closing since there are new changes merged, which may have changes the errors mentioned in this issue.
Created #287 to fix CI

@yonch
Copy link
Contributor

yonch commented Jan 7, 2025

Thank you for opening this issue and contributing #287! I merged your changes (and Jakub's) in #286. Awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants