Skip to content

Commit 887ccaa

Browse files
committed
fix!: change FLAGD_GRPC_TARGET env to FLAGD_TARGET_URI
Signed-off-by: Todd Baert <[email protected]>
1 parent da41a95 commit 887ccaa

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

providers/flagd/README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -104,11 +104,11 @@ variables.
104104
Given below are the supported configurations:
105105

106106
| Option name | Environment variable name | Type & Values | Default | Compatible resolver |
107-
|-----------------------|--------------------------------|--------------------------|-----------|---------------------|
107+
| --------------------- | ------------------------------ | ------------------------ | --------- | ------------------- |
108108
| resolver | FLAGD_RESOLVER | String - rpc, in-process | rpc | |
109109
| host | FLAGD_HOST | String | localhost | rpc & in-process |
110110
| port | FLAGD_PORT | int | 8013 | rpc & in-process |
111-
| targetUri | FLAGD_GRPC_TARGET | string | null | rpc & in-process |
111+
| targetUri | FLAGD_TARGET_URI | string | null | rpc & in-process |
112112
| tls | FLAGD_TLS | boolean | false | rpc & in-process |
113113
| socketPath | FLAGD_SOCKET_PATH | String | null | rpc & in-process |
114114
| certPath | FLAGD_SERVER_CERT_PATH | String | null | rpc & in-process |

providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/Config.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public final class Config {
3737
static final String OFFLINE_SOURCE_PATH = "FLAGD_OFFLINE_FLAG_SOURCE_PATH";
3838
static final String KEEP_ALIVE_MS_ENV_VAR_NAME_OLD = "FLAGD_KEEP_ALIVE_TIME";
3939
static final String KEEP_ALIVE_MS_ENV_VAR_NAME = "FLAGD_KEEP_ALIVE_TIME_MS";
40-
static final String GRPC_TARGET_ENV_VAR_NAME = "FLAGD_GRPC_TARGET";
40+
static final String TARGET_URI_ENV_VAR_NAME = "FLAGD_TARGET_URI";
4141

4242
static final String RESOLVER_RPC = "rpc";
4343
static final String RESOLVER_IN_PROCESS = "in-process";

providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdOptions.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ public class FlagdOptions {
132132
* resolution. For more visit (https://grpc.io/docs/guides/custom-name-resolution/)
133133
*/
134134
@Builder.Default
135-
private String targetUri = fallBackToEnvOrDefault(Config.GRPC_TARGET_ENV_VAR_NAME, null);
135+
private String targetUri = fallBackToEnvOrDefault(Config.TARGET_URI_ENV_VAR_NAME, null);
136136

137137

138138
/**

providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/FlagdOptionsTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ void testRpcProviderFromEnv_portConfigured_usesConfiguredPort() {
191191
}
192192

193193
@Test
194-
@SetEnvironmentVariable(key = GRPC_TARGET_ENV_VAR_NAME, value = "envoy://localhost:1234/foo.service")
194+
@SetEnvironmentVariable(key = TARGET_URI_ENV_VAR_NAME, value = "envoy://localhost:1234/foo.service")
195195
void testTargetOverrideFromEnv() {
196196
FlagdOptions flagdOptions = FlagdOptions.builder().build();
197197

0 commit comments

Comments
 (0)