Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Reduce duplication in connect_service.go #385

Closed
skyerus opened this issue Feb 7, 2023 · 0 comments · Fixed by #391
Closed

[refactor] Reduce duplication in connect_service.go #385

skyerus opened this issue Feb 7, 2023 · 0 comments · Fixed by #391
Assignees
@skyerus
Labels
enhancement New feature or request

Comments

@skyerus
Copy link
Contributor

skyerus commented Feb 7, 2023

Requirements

Recently, a line was removed by accident in a refactoring. This was easily missed as there is a lot of code duplication for each ResolveBoolean,ResolveString, ... method.
Simplify these functions by reducing duplication.
@skyerus skyerus added the enhancement New feature or request label Feb 7, 2023
@skyerus skyerus self-assigned this Feb 7, 2023
@skyerus skyerus mentioned this issue Feb 8, 2023
Merged
skyerus added a commit that referenced this issue Feb 10, 2023
@skyerus
refactor: simplify connect Resolve... funcs (#391)
feebbe2 
## This PR
<!-- add the description of the PR here -->

- Reduces duplicated code in Resolve... funcs

### Related Issues
<!-- add here the GitHub issue that this PR resolves if applicable -->

Fixes #385 

### Notes
<!-- any additional notes for this PR -->

### Follow-up Tasks
<!-- anything that is related to this PR but not done here should be
noted under this section -->
<!-- if there is a need for a new issue, please link it here -->

### How to test
<!-- if applicable, add testing instructions under this section -->
Tested against integration tests.

---------

Signed-off-by: Skye Gill <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skyerus skyerus

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: simplify connect Resolve... funcs skyerus/flagd
1 participant
@skyerus