Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: flatten-dict package #41

Closed
jpmckinney opened this issue Jun 8, 2021 · 1 comment
Closed

Python: flatten-dict package #41

jpmckinney opened this issue Jun 8, 2021 · 1 comment

Comments

@jpmckinney
Copy link
Member

jpmckinney commented Jun 8, 2021

Check whether https://pypi.org/project/flatten-dict/ has similar performance to OCDS Merge's routines, and whether we can use it to eliminate some flattening logic in ocds-merge and lib-cove-ocds (flatten_dict).

Note: There might also be similar logic in the external libraries lib-cove (OpenDataServices/lib-cove#60) and sphinxcontrib-opendataservices (flatten_dict).

@jpmckinney
Copy link
Member Author

jpmckinney commented Dec 11, 2023

Long-term we want to use Rust for OCDS Merge https://github.com/open-contracting/ocds-merge-rs

flatten_dict in lib-cove-ocds is only used for an additional check, which is now skipped in Kingfisher Process (as the check is performed by Pelican instead).

sphinxcontrib-opendataservices doesn't have performance needs, so this issue would have only reduced code duplication. We don't maintain that library though.

lib-cove has other more important performance bottlenecks (OpenDataServices/lib-cove#65) that wouldn't benefit from this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant