From 1e625b69efe4b9b28cc932aaffe157ce295409f1 Mon Sep 17 00:00:00 2001
From: Peter Nose <peter.nose@gmail.com>
Date: Sun, 15 Jan 2023 20:39:11 +0100
Subject: [PATCH] runtime/src/protocol: Remove consensus version compatibility
 check

Consensus version check was a sanity check which didn't allow dump-restore
upgrades. The removal did no harm as the consensus version was never
authenticated and light clients use the verifier to check state compatibility
and authenticity.
---
 .changelog/5135.internal.md   | 6 ++++++
 runtime/src/common/version.rs | 8 --------
 runtime/src/lib.rs            | 5 +----
 runtime/src/protocol.rs       | 6 ------
 4 files changed, 7 insertions(+), 18 deletions(-)
 create mode 100644 .changelog/5135.internal.md

diff --git a/.changelog/5135.internal.md b/.changelog/5135.internal.md
new file mode 100644
index 00000000000..e55605a93db
--- /dev/null
+++ b/.changelog/5135.internal.md
@@ -0,0 +1,6 @@
+runtime/src/protocol: Remove consensus version compatibility check
+
+Consensus version check was a sanity check which didn't allow dump-restore
+upgrades. The removal did no harm as the consensus version was never
+authenticated and light clients use the verifier to check state compatibility
+and authenticity.
diff --git a/runtime/src/common/version.rs b/runtime/src/common/version.rs
index 1d5a53ad285..b752fbd55ed 100644
--- a/runtime/src/common/version.rs
+++ b/runtime/src/common/version.rs
@@ -68,14 +68,6 @@ pub const PROTOCOL_VERSION: Version = Version {
     patch: 0,
 };
 
-// Version of the consensus protocol runtime code works with. This version MUST
-// be compatible with the one supported by the worker host.
-pub const CONSENSUS_VERSION: Version = Version {
-    major: 7,
-    minor: 0,
-    patch: 0,
-};
-
 /// Protocol versions.
 #[derive(Clone, Debug, Default, PartialEq, Eq, Hash, cbor::Encode, cbor::Decode)]
 pub struct ProtocolVersions {
diff --git a/runtime/src/lib.rs b/runtime/src/lib.rs
index f2ff039aa19..1f32da18fda 100644
--- a/runtime/src/lib.rs
+++ b/runtime/src/lib.rs
@@ -38,7 +38,7 @@ pub mod storage;
 pub mod transaction;
 pub mod types;
 
-use crate::common::version::{Version, CONSENSUS_VERSION, PROTOCOL_VERSION};
+use crate::common::version::{Version, PROTOCOL_VERSION};
 
 #[cfg(target_env = "sgx")]
 use self::common::sgx::{EnclaveIdentity, MrSigner};
@@ -82,7 +82,6 @@ lazy_static! {
 
         BuildInfo {
             protocol_version: PROTOCOL_VERSION,
-            consensus_version: CONSENSUS_VERSION,
             is_secure,
         }
     };
@@ -92,8 +91,6 @@ lazy_static! {
 pub struct BuildInfo {
     /// Supported runtime protocol version.
     pub protocol_version: Version,
-    /// Supported consensus protocol version.
-    pub consensus_version: Version,
     /// True iff the build can provide integrity and confidentiality.
     pub is_secure: bool,
 }
diff --git a/runtime/src/protocol.rs b/runtime/src/protocol.rs
index 838515ab127..2a9f166cf79 100644
--- a/runtime/src/protocol.rs
+++ b/runtime/src/protocol.rs
@@ -410,12 +410,6 @@ impl Protocol {
         if tendermint::BACKEND_NAME != host_info.consensus_backend {
             return Err(ProtocolError::IncompatibleConsensusBackend.into());
         }
-        if !BUILD_INFO
-            .consensus_version
-            .is_compatible_with(&host_info.consensus_protocol_version)
-        {
-            return Err(ProtocolError::IncompatibleConsensusBackend.into());
-        }
         let mut local_host_info = self.host_info.lock().unwrap();
         if local_host_info.is_some() {
             return Err(ProtocolError::AlreadyInitialized.into());