Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Unable to view seed words for key created via hot wallet #57

Open
vicariousdrama opened this issue Aug 19, 2024 · 3 comments
Open

Comments

@vicariousdrama
Copy link

The following series of events will leave a new user without the ability to see the seed words to the key

  • Start with no wallets or keys
  • Begin create wallet process
  • Cant make a normal wallet without keys, so choose hot wallet. (wallet and key are created)
  • Click on the wallet, go to its configuration, and immediately delete it.
  • The key for that wallet remains, but it's seed words cannot be viewed to backup.

Any future wallet created in the application that uses this key has a risk of funds loss as recovery is not possible.

Alternatively, perform these steps

  • Start with no wallets or keys
  • Begin create wallet process
  • Cant make a normal wallet without keys, so choose hot wallet. (wallet and key are created)
  • Click on the key and delete it.
  • Click on the wallet, and then attempt the backup by clicking "Do it now" at the top. You'll see the dialog where the action cannot be repeated and to make sure you are ready before proceeding. Click continue. The seed phrase screen will be blank (as the key is gone)

In my ideal world, the app would allow viewing seed words for any hot key being maintained by the app. But barring that, need to do something to avoid footguns that put funds at risk. It's way to easy to delete a key vs a wallet

@hugohn
Copy link
Contributor

hugohn commented Aug 19, 2024

Hi @vicariousdrama

Cant make a normal wallet without keys, so choose hot wallet.

Just to confirm, you mean this is the user's choice (to not create a key before creating a wallet), not a bug in the app that disallows them from doing so, correct?

@vicariousdrama
Copy link
Author

A user has a choice to create a wallet or keys when first entering the application. The natural progression is to try to create a wallet as it is the top most option.

@hugohn
Copy link
Contributor

hugohn commented Aug 19, 2024

As we replied on Nostr, this is an edge case that only happens if you create a hot wallet, don't back it up, delete it (maybe you changed your mind), but then proceed to reuse the key from the (now deleted) hot wallet in a multisig.

As for the fix: We'll disable the delete wallet option if the hot wallet hasn't been backed up yet. Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants