Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspector pause at beginning of recently parsed function will crash #32384

Open
mmarchini opened this issue Mar 20, 2020 · 2 comments
Open

Inspector pause at beginning of recently parsed function will crash #32384

mmarchini opened this issue Mar 20, 2020 · 2 comments
Labels
inspector Issues and PRs related to the V8 inspector protocol v8 engine Issues and PRs related to the V8 dependency.

Comments

@mmarchini
Copy link
Contributor

This is a bug upstream which started once we landed V8 8.1. Opening this issue to keep track of the upstream bug, so we remember to backport once it's fixed.

The bug is unlikely to affect users unless they are using the Inspector protocol to automatically pause a script. The bug happens when the inspector pauses right before a function parsed and compiled with CompileFuncionInContext (and potentially through other means) runs. We have two flaky tests because of this bug.

V8 minimal repro: https://chromium-review.googlesource.com/c/v8/v8/+/2080072
Upstream bug: https://bugs.chromium.org/p/v8/issues/detail?id=10287
First V8 commit with the issue (found with git bisect): https://chromium-review.googlesource.com/c/v8/v8/+/1903440

@targos
Copy link
Member

targos commented Mar 20, 2020

Some background in #32383

@targos targos added inspector Issues and PRs related to the V8 inspector protocol v8 engine Issues and PRs related to the V8 dependency. labels Mar 20, 2020
@targos
Copy link
Member

targos commented Nov 20, 2021

Seems to still be an issue. Now tracked in https://bugs.chromium.org/p/chromium/issues/detail?id=1246905

@targos targos closed this as completed Nov 20, 2021
@targos targos reopened this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inspector Issues and PRs related to the V8 inspector protocol v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

No branches or pull requests

2 participants