Add key bindings for uppercase letters for bold, italic underline

This way, key bindings 'Mod-B', 'Mod-I' and 'Mod-U' with active caps lock have the same effect as their lowercase siblings. This is supposed to be fixed in Tiptap v2 upstream: ueberdosis/tiptap#2426 ueberdosis/tiptap#2478 Fixes: #2050 Signed-off-by: Jonas <[email protected]>
nextcloud · Feb 3, 2022 · 238db0d · 238db0d
1 parent 8379e96
commit 238db0d
Show file tree

Hide file tree

Showing 11 changed files with 47 additions and 17 deletions.
diff --git a/js/editor.js b/js/editor.js
diff --git a/js/editor.js.map b/js/editor.js.map
diff --git a/js/text-files.js b/js/text-files.js
diff --git a/js/text-files.js.map b/js/text-files.js.map
diff --git a/js/text-public.js b/js/text-public.js
diff --git a/js/text-public.js.map b/js/text-public.js.map
diff --git a/js/text-text.js b/js/text-text.js
diff --git a/js/text-text.js.map b/js/text-text.js.map
diff --git a/js/text-viewer.js b/js/text-viewer.js
diff --git a/js/text-viewer.js.map b/js/text-viewer.js.map
diff --git a/src/marks/index.js b/src/marks/index.js
@@ -29,7 +29,7 @@ import {
 } from 'tiptap-extensions'
 import { Plugin } from 'tiptap'
 import { getMarkAttrs } from 'tiptap-utils'
-import { markInputRule, markPasteRule } from 'tiptap-commands'
+import { markInputRule, markPasteRule, toggleMark } from 'tiptap-commands'
 import { domHref, parseHref } from './../helpers/links'
 import markdownit from './../markdownit'
 
@@ -44,6 +44,14 @@ class Strong extends Bold {
 		return 'strong'
 	}
 
+	// TODO: remove once we upgraded to tiptap v2
+	keys({ type }) {
+		return {
+			'Mod-b': toggleMark(type),
+			'Mod-B': toggleMark(type),
+		}
+	}
+
 	// TODO: remove once we upgraded to tiptap v2
 	inputRules({ type }) {
 		return [
@@ -66,6 +74,14 @@ class Italic extends TipTapItalic {
 		return 'em'
 	}
 
+	// TODO: remove once we upgraded to tiptap v2
+	keys({ type }) {
+		return {
+			'Mod-i': toggleMark(type),
+			'Mod-I': toggleMark(type),
+		}
+	}
+
 	// TODO: remove once we upgraded to tiptap v2
 	inputRules({ type }) {
 		return [
@@ -113,6 +129,14 @@ class Strike extends TipTapStrike {
 		}
 	}
 
+	// TODO: remove once we upgraded to tiptap v2
+	keys({ type }) {
+		return {
+			'Mod-d': toggleMark(type),
+			'Mod-D': toggleMark(type),
+		}
+	}
+
 	// TODO: remove once we upgraded to tiptap v2
 	inputRules({ type }) {
 		return [
@@ -229,13 +253,19 @@ class Underline extends TipTapUnderline {
 	}
 
 	// TODO: remove once we upgraded to tiptap v2
+	keys({ type }) {
+		return {
+			'Mod-u': toggleMark(type),
+			'Mod-U': toggleMark(type),
+		}
+	}
+
 	inputRules({ type }) {
 		return [
 			markInputRule(/(?:^|\s)((?:__)((?:[^__]+))(?:__))$/, type),
 		]
 	}
 
-	// TODO: remove once we upgraded to tiptap v2
 	pasteRules({ type }) {
 		return [
 			markPasteRule(/(?:^|\s)((?:__)((?:[^__]+))(?:__))/g, type),