Refactor!: Make package using modules and type only

.github/dependabot.yml

@@ -1,16 +1,17 @@
-# SPDX-FileCopyrightText: 2021 Nextcloud GmbH and Nextcloud contributors
-# SPDX-License-Identifier: GPL-3.0-or-later
+# SPDX-FileCopyrightText: 2019 Nextcloud GmbH and Nextcloud contributors
+# SPDX-License-Identifier: CC0-1.0
+
 version: 2
 updates:
-- package-ecosystem: npm
-  directory: "/"
-  schedule:
-    interval: weekly
-    day: saturday
-    time: "03:00"
-    timezone: Europe/Paris
-  open-pull-requests-limit: 10
-  ignore:
-  - dependency-name: "@types/jquery"
-    versions:
-    - ">= 3.a, < 4"
+  - package-ecosystem: npm
+    directory: '/'
+    schedule:
+      interval: weekly
+      day: saturday
+      time: '03:00'
+      timezone: Europe/Paris
+    open-pull-requests-limit: 10
+    ignore:
+      - dependency-name: '@types/jquery'
+        versions:
+          - '>= 3.a, < 4'

.github/workflows/node.yml → .github/workflows/lint-eslint.yml

@@ -6,15 +6,15 @@
 # SPDX-FileCopyrightText: 2021-2024 Nextcloud GmbH and Nextcloud contributors
 # SPDX-License-Identifier: MIT
 
-name: Node
+name: Lint eslint
 
 on: pull_request
 
 permissions:
   contents: read
 
 concurrency:
-  group: node-${{ github.head_ref || github.run_id }}
+  group: lint-eslint-${{ github.head_ref || github.run_id }}
   cancel-in-progress: true
 
 jobs:
@@ -35,22 +35,24 @@ jobs:
           filters: |
             src:
               - '.github/workflows/**'
-              - 'src/**'
-              - 'appinfo/info.xml'
+              - 'lib/**'
               - 'package.json'
               - 'package-lock.json'
               - 'tsconfig.json'
+              - '.eslintrc.*'
+              - '.eslintignore'
               - '**.js'
               - '**.ts'
               - '**.vue'
 
-  build:
+  lint:
     runs-on: ubuntu-latest
 
     needs: changes
     if: needs.changes.outputs.src != 'false'
 
-    name: NPM build
+    name: NPM lint
+
     steps:
       - name: Checkout
         uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
@@ -70,36 +72,26 @@ jobs:
       - name: Set up npm ${{ steps.versions.outputs.npmVersion }}
         run: npm i -g 'npm@${{ steps.versions.outputs.npmVersion }}'
 
-      - name: Install dependencies & build
+      - name: Install dependencies
         env:
           CYPRESS_INSTALL_BINARY: 0
           PUPPETEER_SKIP_DOWNLOAD: true
-        run: |
-          npm ci
-          npm run build --if-present
-
-      - name: Check webpack build changes
-        run: |
-          bash -c "[[ ! \"`git status --porcelain `\" ]] || (echo 'Please recompile and commit the assets, see the section \"Show changes on failure\" for details' && exit 1)"
+        run: npm ci
 
-      - name: Show changes on failure
-        if: failure()
-        run: |
-          git status
-          git --no-pager diff
-          exit 1 # make it red to grab attention
+      - name: Lint
+        run: npm run lint
 
   summary:
     permissions:
       contents: none
     runs-on: ubuntu-latest
-    needs: [changes, build]
+    needs: [changes, lint]
 
     if: always()
 
     # This is the summary, we just avoid to rename it so that branch protection rules still match
-    name: node
+    name: eslint
 
     steps:
       - name: Summary status
-        run: if ${{ needs.changes.outputs.src != 'false' && needs.build.result != 'success' }}; then exit 1; fi
+        run: if ${{ needs.changes.outputs.src != 'false' && needs.lint.result != 'success' }}; then exit 1; fi

.github/workflows/lint-prettier.yml

@@ -0,0 +1,90 @@
+# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+# SPDX-License-Identifier: MIT
+
+name: Lint prettier
+
+on: pull_request
+
+permissions:
+  contents: read
+
+concurrency:
+  group: lint-prettier-${{ github.head_ref || github.run_id }}
+  cancel-in-progress: true
+
+jobs:
+  changes:
+    runs-on: ubuntu-latest
+
+    outputs:
+      src: ${{ steps.changes.outputs.src}}
+
+    steps:
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
+        id: changes
+        continue-on-error: true
+        with:
+          filters: |
+            src:
+              - '.github/workflows/**'
+              - 'lib/**'
+              - 'package.json'
+              - 'package-lock.json'
+              - 'tsconfig.json'
+              - '.prettierignore'
+              - '**.js'
+              - '**.ts'
+              - '**.vue'
+              - '**.yml'
+              - '**.md'
+
+  lint:
+    runs-on: ubuntu-latest
+
+    needs: changes
+    if: needs.changes.outputs.src != 'false'
+
+    name: NPM format
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+
+      - name: Read package.json node and npm engines version
+        uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3
+        id: versions
+        with:
+          fallbackNode: '^20'
+          fallbackNpm: '^10'
+
+      - name: Set up node ${{ steps.versions.outputs.nodeVersion }}
+        uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v3
+        with:
+          node-version: ${{ steps.versions.outputs.nodeVersion }}
+
+      - name: Set up npm ${{ steps.versions.outputs.npmVersion }}
+        run: npm i -g npm@"${{ steps.versions.outputs.npmVersion }}"
+
+      - name: Install dependencies
+        env:
+          CYPRESS_INSTALL_BINARY: 0
+          PUPPETEER_SKIP_DOWNLOAD: true
+        run: npm ci
+
+      - name: Format
+        run: npm run format
+
+  summary:
+    permissions:
+      contents: none
+    runs-on: ubuntu-latest
+    needs: [changes, lint]
+
+    if: always()
+
+    # This is the summary, we just avoid to rename it so that branch protection rules still match
+    name: prettier
+
+    steps:
+      - name: Summary status
+        run: if ${{ needs.changes.outputs.src != 'false' && needs.lint.result != 'success' }}; then exit 1; fi

.github/workflows/npm-publish.yml

@@ -58,13 +58,3 @@ jobs:
           npm publish
         env:
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
-
-      - name: Setup Github Package Registry
-        uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v3
-        with:
-          registry-url: 'https://npm.pkg.github.com'
-
-      - name: Publish package on GPR
-        run: npm publish
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/reuse.yml

@@ -9,14 +9,14 @@
 
 name: REUSE Compliance Check
 
-on: [pull_request]
+on: pull_request
 
 jobs:
   reuse-compliance-check:
     runs-on: ubuntu-latest
     steps:
-    - name: Checkout
-      uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+      - name: Checkout
+        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
 
-    - name: REUSE Compliance Check
-      uses: fsfe/reuse-action@3ae3c6bdf1257ab19397fab11fd3312144692083 # v4.0.0
+      - name: REUSE Compliance Check
+        uses: fsfe/reuse-action@3ae3c6bdf1257ab19397fab11fd3312144692083 # v4.0.0

.gitignore

@@ -1,5 +1,6 @@
 # SPDX-FileCopyrightText: 2019 Nextcloud GmbH and Nextcloud contributors
-# SPDX-License-Identifier: GPL-3.0-or-later
+# SPDX-License-Identifier: CC0-1.0
+
 # Logs
 logs
 *.log

.prettierignore

@@ -0,0 +1,10 @@
+# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+# SPDX-License-Identifier: CC0-1.0
+
+# version control systems directories
+**/.git
+**/.svn
+**/.hg
+
+# 3rdparty dependencies
+**/node_modules

AUTHORS.md

@@ -1,17 +1,18 @@
 <!--
   - SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
   - SPDX-License-Identifier: GPL-3.0-or-later
--->	
+-->
+
 # Authors
 
-- Andy Scherzinger <[email protected]>
-- Christoph Wurst <[email protected]>
-- Christopher Ng <[email protected]>
-- Ferdinand Thiessen <[email protected]>
-- Georg Ehrke <[email protected]>
-- Greta <[email protected]>
-- Joas Schilling <[email protected]>
-- John Molakvoæ <[email protected]>
-- Julius Härtl <[email protected]>
-- Pytal <[email protected]>
-- Thomas Citharel <[email protected]>
+-   Andy Scherzinger <[email protected]>
+-   Christoph Wurst <[email protected]>
+-   Christopher Ng <[email protected]>
+-   Ferdinand Thiessen <[email protected]>
+-   Georg Ehrke <[email protected]>
+-   Greta <[email protected]>
+-   Joas Schilling <[email protected]>
+-   John Molakvoæ <[email protected]>
+-   Julius Härtl <[email protected]>
+-   Pytal <[email protected]>
+-   Thomas Citharel <[email protected]>