Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): find a replacement to the tabtab dependency, so we can upgrade inquirer #3972

Closed
erezrokah opened this issue Jan 7, 2022 · 4 comments · Fixed by #7057
Closed
Labels
dependencies Pull requests that update a dependency file good first issue type: chore work needed to keep the product and development running smoothly

Comments

@erezrokah
Copy link
Contributor

erezrokah commented Jan 7, 2022

We would like to upgrade inquirer to the latest version.

However doing so will increase our package size significantly since tabtab still references an old inquirer version, so by upgrading inquirer it will no longer get de-duped by npm.

See #3960 (comment)

I opened a PR in tabtab to address the issue, but the repo seems to be unmaintained.

Another alternative is to use a new npm feature called overrides, but that only helps with npm>=8.3.0. See https://github.com/npm/cli/releases/tag/v8.3.0

cc @lukasholzer

@erezrokah erezrokah added type: chore work needed to keep the product and development running smoothly good first issue dependencies Pull requests that update a dependency file labels Jan 7, 2022
@XhmikosR
Copy link
Contributor

XhmikosR commented Jan 7, 2022

I also opened a patch mklabs/tabtab#75 to reduce the package size since right now it's including its coverage folder and all kind of unneeded files.

@erezrokah
Copy link
Contributor Author

We should be able to use https://github.com/pnpm/tabtab and use enquirer, cc @XhmikosR

@XhmikosR
Copy link
Contributor

Should probably update #3941 too later, but the above changes should slim down things a lot. Next biggest issue is TypeScript in precinct.

@erezrokah
Copy link
Contributor Author

Once this is done, we should re-try #4354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file good first issue type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants