Skip to content

Build failed in Win10 + WSL2 #3506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeStarch opened this issue Apr 16, 2025 · 0 comments · May be fixed by #3515
Open

Build failed in Win10 + WSL2 #3506

LeStarch opened this issue Apr 16, 2025 · 0 comments · May be fixed by #3515
Labels
bug High Priority High Priority issue that needs to be resolved.

Comments

@LeStarch
Copy link
Collaborator

Discussed in #3475

Originally posted by AlesKus April 11, 2025
Hello, I have a failed build in WSL2 (Win10Pro).
The changes which cause the error were introduces several weeks ago, but I don't see any issue reported. So, maybe I'm doing something wrong.
What I've done:
fprime-bootstrap clone https://github.com/AlesKus/fprime.git (for now, my fork is synchronized with devel branch 637e812)
cd fprime
. fprime-venv/bin/activate
./ci/tests/Framework.bash
The output:

[INFO] FP Util in /home/alexkus/fprime/fprime running generate
[INFO] FP Util in /home/alexkus/fprime/fprime running generate --ut
[INFO] FP Util in /home/alexkus/fprime/fprime running build with 28 jobs
---------------- ERROR ----------------
Failed to run 'build' in /home/alexkus/fprime/fprime
---------------------------------------
---------------- STDOUT ---------------
....
[ 19%] Built target Os_File_Stub
---------------------------------------
---------------- STDERR ---------------
/home/alexkus/fprime/fprime/Os/Posix/File.cpp:42:54: error: comparison of integer expressions of different signedness: ‘long unsigned int’ and ‘long int’ [-Werror=sign-compare]
   42 | static_assert(std::numeric_limits<FwSizeType>::max() >= std::numeric_limits<off_t>::max(),
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/alexkus/fprime/fprime/Os/Posix/File.cpp:10:
/home/alexkus/fprime/fprime/Os/Posix/File.cpp: In member function ‘virtual Os::FileInterface::Status Os::Posix::File::PosixFile::size(FwSizeType&)’:
/home/alexkus/fprime/fprime/Os/Posix/File.cpp:115:36: error: comparison of integer expressions of different signedness: ‘FwSizeType’ {aka ‘long unsigned int’} and ‘long int’ [-Werror=sign-compare]
  115 |         FW_ASSERT(current_position <= std::numeric_limits<off_t>::max());
      |                   ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/alexkus/fprime/fprime/Fw/Types/Assert.hpp:7:41: note: in definition of macro ‘FW_ASSERT_FIRST_ARG’
    7 | #define FW_ASSERT_FIRST_ARG(ARG_0, ...) ARG_0
      |                                         ^~~~~
/home/alexkus/fprime/fprime/Os/Posix/File.cpp:115:9: note: in expansion of macro ‘FW_ASSERT’
  115 |         FW_ASSERT(current_position <= std::numeric_limits<off_t>::max());
      |         ^~~~~~~~~
/home/alexkus/fprime/fprime/Os/Posix/File.cpp: In member function ‘virtual Os::FileInterface::Status Os::Posix::File::PosixFile::preallocate(FwSizeType, FwSizeType)’:
/home/alexkus/fprime/fprime/Os/Posix/File.cpp:145:17: error: comparison of integer expressions of different signedness: ‘FwSizeType’ {aka ‘long unsigned int’} and ‘long int’ [-Werror=sign-compare]
  145 |     if ((length > std::numeric_limits<off_t>::max()) ||
      |          ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/alexkus/fprime/fprime/Os/Posix/File.cpp:146:17: error: comparison of integer expressions of different signedness: ‘FwSizeType’ {aka ‘long unsigned int’} and ‘long int’ [-Werror=sign-compare]
  146 |         (offset > std::numeric_limits<off_t>::max()) ||
      |          ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/alexkus/fprime/fprime/Os/Posix/File.cpp:170:31: error: comparison of integer expressions of different signedness: ‘FwSizeType’ {aka ‘long unsigned int’} and ‘long int’ [-Werror=sign-compare]
  170 |             if (file_position > std::numeric_limits<FwSignedSizeType>::max() ||
      |                 ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/alexkus/fprime/fprime/Os/Posix/File.cpp:171:27: error: comparison of integer expressions of different signedness: ‘FwSizeType’ {aka ‘long unsigned int’} and ‘long int’ [-Werror=sign-compare]
  171 |                 file_size > std::numeric_limits<FwSignedSizeType>::max()) {
      |                 ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/alexkus/fprime/fprime/Os/Posix/File.cpp: In member function ‘virtual Os::FileInterface::Status Os::Posix::File::PosixFile::read(U8*, FwSizeType&, Os::FileInterface::WaitType)’:
/home/alexkus/fprime/fprime/Os/Posix/File.cpp:234:14: error: comparison of integer expressions of different signedness: ‘FwSizeType’ {aka ‘long unsigned int’} and ‘long int’ [-Werror=sign-compare]
  234 |     if (size > std::numeric_limits<ssize_t>::max()) {
      |         ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/alexkus/fprime/fprime/Os/Posix/File.cpp: In member function ‘virtual Os::FileInterface::Status Os::Posix::File::PosixFile::write(const U8*, FwSizeType&, Os::FileInterface::WaitType)’:
/home/alexkus/fprime/fprime/Os/Posix/File.cpp:275:14: error: comparison of integer expressions of different signedness: ‘FwSizeType’ {aka ‘long unsigned int’} and ‘long int’ [-Werror=sign-compare]
  275 |     if (size > std::numeric_limits<ssize_t>::max()) {
      |         ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
make[2]: *** [F-Prime/Os/Posix/CMakeFiles/Os_File_Posix.dir/build.make:63: F-Prime/Os/Posix/CMakeFiles/Os_File_Posix.dir/File.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:6920: F-Prime/Os/Posix/CMakeFiles/Os_File_Posix.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:84: all] Error 2
[ERROR] CMake erred with return code 2

Versions:

fprime-util version-check
Operating System: Linux
CPU Architecture: x86_64
Platform: Linux-5.10.74.3-microsoft-standard-WSL2+-x86_64-with-glibc2.29
Python version: 3.8.10
CMake version: 3.16.3
Pip version: 25.0.1
Pip packages:
    fprime-tools==3.6.1
    fprime-gds==3.6.1
    fprime-fpp-*==3.0.0a7
Project submodules:

It looks somewhat similar to #3030. But, again, I don't see any issues or discussions about this, therefore my questions are:

  1. Does anyone observe this behavior?
  2. Is my command line sequence correct?
@LeStarch LeStarch added bug High Priority High Priority issue that needs to be resolved. labels Apr 16, 2025
@thomas-bc thomas-bc changed the title frpime:devel build failed in Win10 + WSL2 Build failed in Win10 + WSL2 Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug High Priority High Priority issue that needs to be resolved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant