Merge pull request #80 from thnkslprpt/fix-79-combine-mutually-exclusive-status-checks

dzbaker · web-flow · commit 45f8e87dc985 · 2023-04-27T14:52:04.000-04:00
Fix #79, Combine consecutive, mutually-exclusive status checks
diff --git a/fsw/src/lc_app.c b/fsw/src/lc_app.c
@@ -522,8 +522,7 @@ int32 LC_CreateResultTables(void)
         CFE_EVS_SendEvent(LC_WRT_REGISTER_ERR_EID, CFE_EVS_EventType_ERROR, "Error registering WRT, RC=0x%08X",
                           (unsigned int)Result);
     }
-
-    if (Result == CFE_SUCCESS)
+    else
     {
         Result = CFE_TBL_GetAddress((void *)&LC_OperData.WRTPtr, LC_OperData.WRTHandle);
 

Original file line number	Diff line number	Diff line change
`@@ -522,8 +522,7 @@ int32 LC_CreateResultTables(void)`
`522`	`522`	`CFE_EVS_SendEvent(LC_WRT_REGISTER_ERR_EID, CFE_EVS_EventType_ERROR, "Error registering WRT, RC=0x%08X",`
`523`	`523`	`(unsigned int)Result);`
`524`	`524`	`}`
`525`		`-`
`526`		`- if (Result == CFE_SUCCESS)`
	`525`	`+ else`
`527`	`526`	`{`
`528`	`527`	`Result = CFE_TBL_GetAddress((void *)&LC_OperData.WRTPtr, LC_OperData.WRTHandle);`
`529`	`528`