From c8e77046a7fb8e7830a6d7bab3fc88ea7a903610 Mon Sep 17 00:00:00 2001 From: Floris Bruynooghe Date: Tue, 18 Jun 2024 14:05:20 +0200 Subject: [PATCH 1/2] tests(iroh-net): Remove a flaky test This flakyness seems to have been successfully addressed by the staggered DNS lookup. Converting this test to that basically results in the same code as the next test: test_dns_lookup_ipv4_ipv6. So just remove this test as it no longer provides value. --- iroh-net/src/dns.rs | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/iroh-net/src/dns.rs b/iroh-net/src/dns.rs index 1ac64c2f7f..bcd5ebc15a 100644 --- a/iroh-net/src/dns.rs +++ b/iroh-net/src/dns.rs @@ -387,17 +387,6 @@ pub(crate) mod tests { const TIMEOUT: Duration = Duration::from_secs(5); const STAGGERING_DELAYS: &[u64] = &[200, 300]; - #[tokio::test] - #[cfg_attr(target_os = "windows", ignore = "flaky")] - async fn test_dns_lookup_basic() { - let _logging = iroh_test::logging::setup(); - let resolver = default_resolver(); - let res = resolver.lookup_ip(NA_RELAY_HOSTNAME).await.unwrap(); - let res: Vec<_> = res.iter().collect(); - assert!(!res.is_empty()); - dbg!(res); - } - #[tokio::test] async fn test_dns_lookup_ipv4_ipv6() { let _logging = iroh_test::logging::setup(); From 818d706b34e8d3c263d9f3b5954f576c9d617151 Mon Sep 17 00:00:00 2001 From: Floris Bruynooghe Date: Tue, 18 Jun 2024 16:06:04 +0200 Subject: [PATCH 2/2] tests(iroh): disable flaky test_default_author_presist --- iroh/src/node.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/iroh/src/node.rs b/iroh/src/node.rs index d156c242d6..ac1bee9548 100644 --- a/iroh/src/node.rs +++ b/iroh/src/node.rs @@ -415,6 +415,7 @@ mod tests { } #[cfg(feature = "fs-store")] + #[ignore = "flaky"] #[tokio::test] async fn test_default_author_persist() -> Result<()> { use crate::util::path::IrohPaths;