Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling network changes and rebinding #2049

Closed
flub opened this issue Feb 29, 2024 · 1 comment
Closed

Handling network changes and rebinding #2049

flub opened this issue Feb 29, 2024 · 1 comment
Assignees
@flub
Labels
c-iroh flaky-test

Comments

@flub
Copy link
Contributor

flub commented Feb 29, 2024

Iroh does not yet handle network changes as well as it should, one such scenario is demonstrated by the flakyness of iroh_net::magicsock::tests::test_two_devices_roundtrip_network_change.

Overall this should be improved and have a few more (non-flaky) tests.
@flub flub self-assigned this Feb 29, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in iroh Feb 29, 2024
@flub flub changed the title Handling network changes Handling network changes and rebinding Feb 29, 2024
@flub flub moved this from 📋 Backlog to 🔖 Ready in iroh Feb 29, 2024
@flub flub mentioned this issue Feb 29, 2024
Closed
@ramfox ramfox moved this to 📋 Backlog in iroh Apr 10, 2024
@flub
Copy link
Contributor Author

flub commented Apr 23, 2024

We instead removed rebinding in #2083

@flub flub closed this as completed Apr 23, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in iroh Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flub flub

Labels
c-iroh flaky-test
Projects
iroh
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flub