Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][nextjs] Logo in branding is not vertically aligned with title #4782

Closed
jakobmerrild opened this issue Mar 18, 2025 · 1 comment · Fixed by #4784
Closed

[core][nextjs] Logo in branding is not vertically aligned with title #4782

jakobmerrild opened this issue Mar 18, 2025 · 1 comment · Fixed by #4784
Assignees
Labels
core Infrastructure work going on behind the scenes nextjs Toolpad

Comments

@jakobmerrild
Copy link
Contributor

jakobmerrild commented Mar 18, 2025

Steps to reproduce

Steps:

  1. Bootstrap toolpad core nextjs example: https://github.com/mui/toolpad/tree/master/examples/core/auth-nextjs

  2. const BRANDING = {
    title: 'My Toolpad Core Next.js App',
    };

    a. Add logo using Next/Image, e.g. <Image src='/logo.png' alt='' width={30} height={30} />

  3. Notice that logo isn't aligned with title.

Current behavior

When providing the logo of Branding to NextAppRouter (and possibly also DashboardLayout) it doesn't align vertically with the title

Expected behavior

The logo and title should be vertically aligned.

This could of course be achieved by using the new appTitle slot in the DashboardLayout, but that slot isn't available on the NextAppProvider, but ultimately the expectation is that the logo and title align.

Context

Using the documentation provided to integrate Toolpad Core with NextJS I would like to be able to have simple configuration of Branding that aligns the different elements inside the Stack used for the AppTitle

Your environment

npx @mui/envinfo

  System:
    OS: macOS 15.3.1
  Binaries:
    Node: 22.14.0 - ~/.nvm/versions/node/v22.14.0/bin/node
    npm: 10.9.2 - ~/.nvm/versions/node/v22.14.0/bin/npm
    pnpm: Not Found
  Browsers:
    Chrome: 134.0.6998.89
    Edge: Not Found
    Safari: 18.3
  npmPackages:
    @emotion/react: ^11.14.0 => 11.14.0 
    @emotion/styled: ^11.14.0 => 11.14.0 
    @mui/base:  5.0.0-beta.58 
    @mui/core-downloads-tracker:  6.4.6 
    @mui/icons-material: ^6.4.1 => 6.4.6 
    @mui/lab: 6.0.0-beta.10 => 6.0.0-beta.10 
    @mui/material: ^6.4.1 => 6.4.6 
    @mui/material-nextjs: ^6.3.1 => 6.4.3 
    @mui/private-theming:  6.4.6 
    @mui/styled-engine:  6.4.6 
    @mui/system:  6.4.6 
    @mui/types:  7.2.21 
    @mui/utils:  6.4.6 
    @mui/x-date-pickers: ^7.24.1 => 7.27.1 
    @mui/x-internals:  7.26.0 
    @toolpad/core: ^0.13.0 => 0.13.0 
    @toolpad/utils:  0.13.0 
    @types/react: ^19.0.8 => 19.0.10 
    react: ^19.0.0 => 19.0.0 
    react-dom: ^19.0.0 => 19.0.0 
    typescript: ^5.7.3 => 5.7.3 

Search keywords: branding apptitle logo

@jakobmerrild jakobmerrild added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Mar 18, 2025
jakobmerrild added a commit to jakobmerrild/toolpad that referenced this issue Mar 18, 2025
jakobmerrild added a commit to jakobmerrild/toolpad that referenced this issue Mar 18, 2025
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@github-actions github-actions bot removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Mar 24, 2025
@zannager zannager added core Infrastructure work going on behind the scenes Toolpad nextjs labels Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes nextjs Toolpad
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants