[core] [i18n] Add interpolation to translation keys #4773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy preview |
Janpot
reviewed
Mar 17, 2025
| @@ -1,5 +1,12 @@ | |||
| { | |||
| "props": { "localeText": { "type": { "name": "object" } } }, | |||
| "props": { | |||
| "localeText": { | |||
There was a problem hiding this comment.
Can we keep this type the same as in X?
Janpot
reviewed
Mar 17, 2025
| @@ -105,7 +103,47 @@ LocalizationProvider.propTypes /* remove-proptypes */ = { | |||
| /** | |||
| * Locale for components texts | |||
| */ | |||
| localeText: PropTypes.object, | |||
There was a problem hiding this comment.
I believe this was deliberate, as in https://github.com/mui/mui-x/blob/7b956af2cf425c4b8a21cee6876f448e3337026f/packages/x-date-pickers/src/TimePicker/TimePicker.tsx#L135
There was a problem hiding this comment.
Yes, but I felt that having the explicit props is helpful at least on the LocalizationProvider docs, it is typed as object for every other component. We can revert it if you think it doesn't make sense
There was a problem hiding this comment.
We can revert it if you think it doesn't make sense
It makes sense, but I think it makes more sense to be consistent with X
Janpot
approved these changes
Mar 17, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
providerSignInTitleof a(provider: string) => stringtypesignInTitleto astring | ((brandingTitle?: string) => string)typeBreaking Change
oauthSignInTitle,passkeySignInTitleandmagicLinkSignInTitle