Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SnackBar] Port Component #6269

Closed
5 tasks
stunaz opened this issue Mar 3, 2017 · 3 comments
Closed
5 tasks

[SnackBar] Port Component #6269

stunaz opened this issue Mar 3, 2017 · 3 comments
Labels
component: snackbar This is the name of the generic UI component, not the React module!

Comments

@stunaz
Copy link
Contributor

stunaz commented Mar 3, 2017

First attempts that are closed form beeing finished:

@Shahrukh-Zindani Shahrukh-Zindani self-assigned this Mar 3, 2017
@Shahrukh-Zindani Shahrukh-Zindani added next component: snackbar This is the name of the generic UI component, not the React module! labels Mar 3, 2017
@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 3, 2017

@stunaz Thanks for opening this issue. @Shahrukh-Zindani plan to start with this one.
This is how I would move forward with the migration. Any feedback is welcomed. We should be able to close all the issues related to that component with not too much pain 😄 .

API

/**
 * Fired when the `SnackBar` is requested to be closed by a click outside it.
 */
onRequestClose: PropTypes.func,
/**
 * Controls whether the SnackBar is opened or not.
 */
open: PropTypes.bool.isRequired,

Implementation

@justinmasse
Copy link

Any news on the progress of porting this to the next branch? Need something like it for a current project and just trying to figure out if I should code a quick solution for it in the meantime.

@mbrookes
Copy link
Member

@justinmasse There were two good starts made (see the initial issue comment), so if you'd like to take the best of both, a PR would be very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: snackbar This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

5 participants