Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old ISO 6346 standart used #16

Closed
snussik opened this issue Jan 3, 2024 · 4 comments
Closed

Old ISO 6346 standart used #16

snussik opened this issue Jan 3, 2024 · 4 comments

Comments

@snussik
Copy link

snussik commented Jan 3, 2024

It seems, that json configs contain old data from ISO6346:1995 (am. 1 2017). 2020 revision has significant changes in container type marking.

@mrclmr
Copy link
Owner

mrclmr commented Jan 3, 2024

It seems, that json configs contain old data from ISO6346:1995 (am. 1 2017). 2020 revision has significant changes in container type marking.

Thanks for open this issue :) Could you pinpoint me to a good source of the ISO6346:2020 revision? And do you know which types are missing in https://github.com/meyermarcel/icm/blob/main/data/file/type.json?

@snussik
Copy link
Author

snussik commented Jan 3, 2024

It seems, that json configs contain old data from ISO6346:1995 (am. 1 2017). 2020 revision has significant changes in container type marking.

Thanks for open this issue :) Could you pinpoint me to a good source of the ISO6346:2020 revision? And do you know which types are missing in https://github.com/meyermarcel/icm/blob/main/data/file/type.json?

I don't have actual revision too. By the way, its actual revision is 2022, now ))
But I've noticed that tanks have "k" letter: https://www.bic-code.org/type-code-designation/

If I find actual version I'll try to make a revision and pr.

@mrclmr
Copy link
Owner

mrclmr commented Jan 3, 2024

It seems, that json configs contain old data from ISO6346:1995 (am. 1 2017). 2020 revision has significant changes in container type marking.

Thanks for open this issue :) Could you pinpoint me to a good source of the ISO6346:2020 revision? And do you know which types are missing in https://github.com/meyermarcel/icm/blob/main/data/file/type.json?

I don't have actual revision too. By the way, its actual revision is 2022, now )) But I've noticed that tanks have "k" letter: https://www.bic-code.org/type-code-designation/

Thanks for the link!

If I find actual version I'll try to make a revision and pr.

I had some time and created a PR: #17

@mrclmr
Copy link
Owner

mrclmr commented Jan 15, 2024

@snussik 👋

@mrclmr mrclmr closed this as completed Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants