Skip to content

Commit 2edfdd8

Browse files
committed
fix(topologies): unify topologies connect API
Eliminates the DB parameter from the `connect` call in replset and mongos to unify the api with server
1 parent f608f44 commit 2edfdd8

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

lib/topologies/mongos.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ class Mongos extends TopologyBase {
209209
}
210210

211211
// Connect
212-
connect(db, _options, callback) {
212+
connect(_options, callback) {
213213
var self = this;
214214
if ('function' === typeof _options) (callback = _options), (_options = {});
215215
if (_options == null) _options = {};
@@ -218,7 +218,8 @@ class Mongos extends TopologyBase {
218218
self.s.options = _options;
219219

220220
// Update bufferMaxEntries
221-
self.s.storeOptions.bufferMaxEntries = db.bufferMaxEntries;
221+
self.s.storeOptions.bufferMaxEntries =
222+
typeof _options.bufferMaxEntries === 'number' ? _options.bufferMaxEntries : -1;
222223

223224
// Error handler
224225
var connectErrorHandler = function() {

lib/topologies/replset.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ class ReplSet extends TopologyBase {
236236
}
237237

238238
// Connect method
239-
connect(db, _options, callback) {
239+
connect(_options, callback) {
240240
var self = this;
241241
if ('function' === typeof _options) (callback = _options), (_options = {});
242242
if (_options == null) _options = {};
@@ -245,7 +245,8 @@ class ReplSet extends TopologyBase {
245245
self.s.options = _options;
246246

247247
// Update bufferMaxEntries
248-
self.s.storeOptions.bufferMaxEntries = db.bufferMaxEntries;
248+
self.s.storeOptions.bufferMaxEntries =
249+
typeof _options.bufferMaxEntries === 'number' ? _options.bufferMaxEntries : -1;
249250

250251
// Actual handler
251252
var errorHandler = function(event) {

0 commit comments

Comments
 (0)