From fe50f8b777ba9875d4577cbdf033940a646ff697 Mon Sep 17 00:00:00 2001 From: Maxime Beauchemin Date: Wed, 4 Oct 2017 10:17:01 -0700 Subject: [PATCH] [sql lab] fix numeric sort in data table (#3587) Currently numerical values sort as alpha, this addresses the issue. --- .../javascripts/components/FilterableTable/FilterableTable.jsx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/superset/assets/javascripts/components/FilterableTable/FilterableTable.jsx b/superset/assets/javascripts/components/FilterableTable/FilterableTable.jsx index f72014ab97401..7874aab921ce0 100644 --- a/superset/assets/javascripts/components/FilterableTable/FilterableTable.jsx +++ b/superset/assets/javascripts/components/FilterableTable/FilterableTable.jsx @@ -82,7 +82,7 @@ export default class FilterableTable extends PureComponent { const newRow = {}; for (const k in row) { const val = row[k]; - if (typeof (val) === 'string') { + if (['string', 'number'].indexOf(typeof (val)) >= 0) { newRow[k] = val; } else { newRow[k] = JSON.stringify(val); @@ -150,7 +150,6 @@ export default class FilterableTable extends PureComponent { } const rowGetter = ({ index }) => this.getDatum(sortedAndFilteredList, index); - return (