From 2d7ddbac478abfc9c08e569d028adeed69fdcfe6 Mon Sep 17 00:00:00 2001 From: Maxime Beauchemin Date: Tue, 13 Feb 2018 11:17:19 -0800 Subject: [PATCH] Unset 'series limit' default from 50 to null (#4410) Setting "Series Limit" by default results in a subquery (or 2 phase) which can be suboptimal / unecessary where low cardinality dims are used. --- superset/assets/javascripts/explore/stores/controls.jsx | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/superset/assets/javascripts/explore/stores/controls.jsx b/superset/assets/javascripts/explore/stores/controls.jsx index e8a34d950db47..007523c4d1e4a 100644 --- a/superset/assets/javascripts/explore/stores/controls.jsx +++ b/superset/assets/javascripts/explore/stores/controls.jsx @@ -870,8 +870,11 @@ export const controls = { label: t('Series limit'), validators: [v.integer], choices: formatSelectOptions(SERIES_LIMITS), - default: 50, - description: t('Limits the number of time series that get displayed'), + description: t( + 'Limits the number of time series that get displayed. A sub query ' + + '(or an extra phase where sub queries are not supported) is applied to limit ' + + 'the number of time series that get fetched and displayed. This feature is useful ' + + 'when grouping by high cardinality dimension(s).'), }, timeseries_limit_metric: {