Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Peek and Poke to binary / cereal naming #35

Closed
mgsloan opened this issue May 31, 2016 · 2 comments
Closed

Rename Peek and Poke to binary / cereal naming #35

mgsloan opened this issue May 31, 2016 · 2 comments

Comments

@mgsloan
Copy link
Owner

mgsloan commented May 31, 2016

We are already considering some breaking changes: #21

So this is a good time to consider other ones. While considering #31, it occurred to me that it may be convenient to make store's naming more consistent with binary. This would make it more straightforward to port code from binary to store. Some changes would need to change, but most of the time the custom implementations of put or get would not.

@mgsloan
Copy link
Owner Author

mgsloan commented May 31, 2016

One downside is that it might imply that the ported code would have the same binary representation. We'd just need to document that it doesn't.

@mgsloan
Copy link
Owner Author

mgsloan commented May 31, 2016

Closing this in favor of using this naming for architecture independent serialization - #36

@mgsloan mgsloan closed this as completed May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant