Implement precision option

mgreter · Mar 18, 2014 · 9604b09 · 9604b09 · mgreter · Mar 18, 2014
1 parent 79b74c9
commit 9604b09
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/lib/CSS/Sass.xs b/lib/CSS/Sass.xs
@@ -182,6 +182,7 @@ compile_sass(input_string, options)
         SV **output_style_sv    = hv_fetch_key(options, "output_style",    false);
         SV **source_comments_sv = hv_fetch_key(options, "source_comments", false);
         SV **include_paths_sv   = hv_fetch_key(options, "include_paths",   false);
+        SV **precision_sv       = hv_fetch_key(options, "precision",       false);
         SV **image_path_sv      = hv_fetch_key(options, "image_path",      false);
         SV **source_map_file_sv = hv_fetch_key(options, "source_map_file", false);
         SV **sass_functions_sv  = hv_fetch_key(options, "sass_functions",  false);
@@ -195,6 +196,8 @@ compile_sass(input_string, options)
             ctx->options.source_comments = SvUV(*source_comments_sv);
         if (include_paths_sv)
             ctx->options.include_paths = safe_svpv(*include_paths_sv, "");
+        if (precision_sv)
+            ctx->options.precision = SvUV(*precision_sv);
         if (image_path_sv)
             ctx->options.image_path = safe_svpv(*image_path_sv, "");
         if (source_map_file_sv)
@@ -262,6 +265,7 @@ compile_sass_file(input_path, options)
         SV **output_style_sv    = hv_fetch_key(options, "output_style",    false);
         SV **source_comments_sv = hv_fetch_key(options, "source_comments", false);
         SV **include_paths_sv   = hv_fetch_key(options, "include_paths",   false);
+        SV **precision_sv       = hv_fetch_key(options, "precision",       false);
         SV **image_path_sv      = hv_fetch_key(options, "image_path",      false);
         SV **source_map_file_sv = hv_fetch_key(options, "source_map_file", false);
         SV **sass_functions_sv  = hv_fetch_key(options, "sass_functions",  false);
@@ -273,6 +277,8 @@ compile_sass_file(input_path, options)
             ctx->options.source_comments = SvUV(*source_comments_sv);
         if (include_paths_sv)
             ctx->options.include_paths = safe_svpv(*include_paths_sv, "");
+        if (precision_sv)
+            ctx->options.precision = SvUV(*precision_sv);
         if (image_path_sv)
             ctx->options.image_path = safe_svpv(*image_path_sv, "");
         if (source_map_file_sv)

diff --git a/libsass b/libsass
diff --git a/t/01_xs.t b/t/01_xs.t
@@ -6,7 +6,7 @@
 use strict;
 use warnings;
 
-use Test::More tests => 42;
+use Test::More tests => 48;
 BEGIN { use_ok('CSS::Sass') };
 
 my $r;
@@ -90,3 +90,13 @@ like  ($r->{output_string}, qr@url\("/a/b/c/path"\)@, "image_path works");
 $r = CSS::Sass::compile_sass('.valid { color: image-url("path"); }', { image_path => { wrong_type => 1 } });
 is    ($r->{error_status},  0,                        "image_path w/ bad type no error_status and doesn't crash");
 is    ($r->{error_message}, undef,                    "image_path w/ bad type error_message is undef");
+
+$r = CSS::Sass::compile_sass('.valid { width: #{(1/3)}; }', { include_paths => 't/inc' });
+is    ($r->{error_status},  0,                        "import no error_status");
+is    ($r->{error_message}, undef,                    "import error_message is undef");
+like  ($r->{output_string}, qr/0\.33333;/,            "default float precision is 5");
+
+$r = CSS::Sass::compile_sass('.valid { width: #{(1/3)}; }', { include_paths => 't/inc', precision => 10 });
+is    ($r->{error_status},  0,                        "import no error_status");
+is    ($r->{error_message}, undef,                    "import error_message is undef");
+like  ($r->{output_string}, qr/0\.3333333333;/,       "float precision of 10");
+2 −2		ast.hpp
+1 −0		context.cpp
+4 −1		context.hpp
+10 −1		contextualize.cpp
+1 −1		eval.cpp
+4 −2		functions.cpp
+24 −21		inspect.cpp
+13 −3		parser.cpp
+2 −2		prelexer.cpp
+1 −0		sass.cpp
+1 −0		sass.h
+2 −0		sass_interface.cpp
+1 −0		sass_interface.h