Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in AGE calculation for estrogen piece #5

Open
kylebaron opened this issue Jul 26, 2018 · 1 comment
Open

Bug in AGE calculation for estrogen piece #5

kylebaron opened this issue Jul 26, 2018 · 1 comment
Assignees
Labels

Comments

@kylebaron
Copy link
Contributor

@riggsmm

https://github.com/metrumresearchgroup/OpenBoneMin/blob/master/inst/OpenBoneMin.cpp#L634

double AGE = ageENTER + T_0;

should be ??

double AGE = ageENTER + SOLVERTIME;
@kylebaron kylebaron changed the title AGE calculation Bug in AGE calculation for estrogen piece Jul 26, 2018
@kylebaron kylebaron added the bug label Jul 26, 2018
@riggsmm
Copy link

riggsmm commented Jul 26, 2018

Good catch -- mis-translated from the Berkeley-Madonna original code ("Age = startAge + TIME/(24*365.25)") as posted in .mmd file in online Supporting Information (psp4201210-sup-0004.zipZip archive, 17.3 KB Supplementary Data 2) available at: https://ascpt.onlinelibrary.wiley.com/doi/abs/10.1038/psp.2012.10

kylebaron added a commit that referenced this issue Jul 26, 2018
kylebaron added a commit that referenced this issue Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants