Fix url resolving in user/group role serializers

This also adds a corresponding PRN field.

fixes pulp#6330

Author: mdellweg

CHANGES/6330.bugfix

@@ -0,0 +1 @@
+Fixed a server error when listing user roles.

pulpcore/app/serializers/user.py

@@ -26,6 +26,9 @@
 from pulpcore.app.util import (
     get_viewset_for_model,
     get_request_without_query_params,
+    get_url,
+    get_prn,
+    resolve_prn,
 )
 
 User = get_user_model()
@@ -60,27 +63,42 @@ def to_internal_value(self, data):
 class ContentObjectField(serializers.CharField):
     """Content object field"""
 
-    def to_representation(self, obj):
-        content_object = getattr(obj, "content_object", None)
-        if content_object:
-            viewset = get_viewset_for_model(obj.content_object)
-
+    def to_representation(self, value):
+        if value is None:
+            return None
+        else:
             request = get_request_without_query_params(self.context)
+            return get_url(value, request=request)
 
-            serializer = viewset.serializer_class(obj.content_object, context={"request": request})
-            return serializer.data.get("pulp_href")
-
-    def to_internal_value(self, data):
+    def to_internal_value(self, value):
         # ... circular import ...
         from pulpcore.app.viewsets.base import NamedModelViewSet
 
-        if data is None:
-            return {"content_object": None}
-        try:
-            obj = NamedModelViewSet.get_resource(data)
-        except serializers.ValidationError:
-            raise serializers.ValidationError(_("Invalid value: {}.").format(data))
-        return {"content_object": obj}
+        if value is None:
+            return None
+        else:
+            try:
+                obj = NamedModelViewSet.get_resource(value)
+            except serializers.ValidationError:
+                raise serializers.ValidationError(_("Invalid value: {}.").format(value))
+            return obj
+
+
+class ContentObjectPRNField(serializers.CharField):
+    """Content object PRN field"""
+
+    def to_representation(self, value):
+        if value is None:
+            return None
+        else:
+            return get_prn(value)
+
+    def to_internal_value(self, value):
+        if value is None:
+            return None
+        else:
+            model, pk = resolve_prn(value)
+            return model.objects.get(pk=pk)
 
 
 class UserGroupSerializer(serializers.ModelSerializer):
@@ -308,10 +326,19 @@ class UserRoleSerializer(ValidateRoleMixin, ModelSerializer, NestedHyperlinkedMo
             "pulp_href of the object for which role permissions should be asserted. "
             "If set to 'null', permissions will act on either domain or model-level."
         ),
-        source="*",
         allow_null=True,
     )
 
+    content_object_prn = ContentObjectPRNField(
+        help_text=_(
+            "prn of the object for which role permissions should be asserted. "
+            "If set to 'null', permissions will act on either domain or model-level."
+        ),
+        source="content_object",
+        allow_null=True,
+        required=False,
+    )
+
     domain = RelatedField(
         help_text=_(
             "Domain this role should be applied on, mutually exclusive with content_object."
@@ -343,6 +370,7 @@ class Meta:
         fields = ModelSerializer.Meta.fields + (
             "role",
             "content_object",
+            "content_object_prn",
             "description",
             "permissions",
             "domain",
@@ -366,10 +394,19 @@ class GroupRoleSerializer(ValidateRoleMixin, ModelSerializer, NestedHyperlinkedM
             "pulp_href of the object for which role permissions should be asserted. "
             "If set to 'null', permissions will act on the model-level."
         ),
-        source="*",
         allow_null=True,
     )
 
+    content_object_prn = ContentObjectPRNField(
+        help_text=_(
+            "prn of the object for which role permissions should be asserted. "
+            "If set to 'null', permissions will act on either domain or model-level."
+        ),
+        source="content_object",
+        allow_null=True,
+        required=False,
+    )
+
     domain = RelatedField(
         help_text=_(
             "Domain this role should be applied on, mutually exclusive with content_object."
@@ -403,6 +440,7 @@ class Meta:
         fields = ModelSerializer.Meta.fields + (
             "role",
             "content_object",
+            "content_object_prn",
             "description",
             "permissions",
             "domain",

pulpcore/app/util.py

@@ -66,18 +66,19 @@ def get_url(model, domain=None, request=None):
         str: The path component of the resource url
     """
     kwargs = {}
-    view_action = "list"
     if settings.DOMAIN_ENABLED:
         kwargs["pulp_domain"] = "default"
-        if not domain and hasattr(model, "pulp_domain") and isinstance(model, model._meta.model):
+        if not domain and hasattr(model, "pulp_domain") and isinstance(model, Model):
             kwargs["pulp_domain"] = model.pulp_domain.name
         elif isinstance(domain, models.Domain):
             kwargs["pulp_domain"] = domain.name
         elif isinstance(domain, str):
             kwargs["pulp_domain"] = domain
-    if isinstance(model, model._meta.model):
+    if isinstance(model, Model):
         view_action = "detail"
         kwargs["pk"] = model.pk
+    else:
+        view_action = "list"
 
     return reverse(get_view_name_for_model(model, view_action), kwargs=kwargs, request=request)