Improvments

[devmondo]

hi,
may i suggest the following features to make this more beautiful

-ability to have options to confirm Tag, right now only Enter key is used, we may have space Key and Tab key too

• i have noticed in the examples if you type a new tag that is not in the source data when Ajax is used as source, you cant enter it, thus will prevent users from adding new values that are not there in the Ajax operation
• have a minimum characters entered before issuing Ajax to improve performance
  -have a way to validate the tag before approving it
• a way to edit the tag instead of removing it and retyping the desired one, maybe you made spelling mistake, so there is no need to delete, just click on the tag and edit.
  -if user clicks ESC button the entered text should be cleared
  -events on adding, editing, deleting, initializing

thanks in advanced.

[timschlechter]

Thanks for the feedback. I created some separate issues for typeahead options and the events, I think they're a good idea. Validating a tag could be done in the beforeadd event.

Minimum characters before actually querying an resource by ajax can easily be done by setting a function as source option, which checks query.length before invoking the ajax call.

I'm not sure about the tab key, I think it's good to explicitly confirm adding a tag by hitting enter. Space is not possible, because tags may contain spaces.

Also not sure about editting tags, because I'm thinking about making tags clickable (trigger click event)

[devmondo]

thanks for reply,
-is there a documentation for beforeaddtag and any other events as i don't see it ?
-regarding the characters count, it could not be simpler, thanks for the tip
-regarding tab key, i think you are spot on, in fact after implementing your plugin, i have faced same issue you mentioned with a client, so you are correct
-regarding editing tag, making tag clickable is great, maybe we can hook into that and show text box to edit ("in place editing") this would be awesome.

lastly if we can reorder the tags by dragging this would make it a bomb :)

thanks for listening

[timschlechter]

"is there a documentation for beforeaddtag and any other events as i don't see it ?"
Nope, they're not implemented yet. Don't know exactly when I'll come to this. Feel free to help and send a pull request though :-)

"lastly if we can reorder the tags by dragging this would make it a bomb"
Ordering tags is somthing I'm thinking about to add in the future, Drag-drop would fit nice in that.

[devmondo]

awesome, speaking of pull request, how this damn thing works ?

[timschlechter]

https://help.github.com/articles/using-pull-requests

[devmondo]

great thank you :)

[timschlechter]

Got some more feedback about which keys to use to confirm a tag. Some people like space too. Created #10 for this.

[timschlechter]

I think all relevant enhancements from this issue are covered in new issues; closing this one

[devmondo]

great, all the best

[viral7194]

hi,

I agreed regarding to @devmondo for confirm tag through tab key..
it would be great if you introduce tab key in your control

Thanks in Advanced