Skip to content

Commit 919c4b2

Browse files
committed
Mark ambiguous float / long as deprecated
Microsoft themselves warn against using that kind of notation. Tests changed to reflect the new designation.
1 parent bea280e commit 919c4b2

File tree

2 files changed

+26
-2
lines changed

2 files changed

+26
-2
lines changed

PowerShell.sublime-syntax

+18
Original file line numberDiff line numberDiff line change
@@ -560,6 +560,24 @@ contexts:
560560
2: punctuation.definition.numeric.base.powershell
561561
3: storage.type.numeric.powershell
562562
4: keyword.other.unit.powershell
563+
- match: |-
564+
(?x:
565+
(
566+
\b{{dec_digits}}
567+
(?:
568+
(?:
569+
(?:(?:\.(?!\.))\d*) # No `_` after the `.`
570+
{{dec_exponent}}?
571+
| {{dec_exponent}}
572+
)
573+
(?:{{integer_suffix}})
574+
)
575+
)
576+
({{bytes_unit}}\b)?
577+
)
578+
captures:
579+
1: invalid.deprecated.powershell
580+
2: keyword.other.unit.powershell
563581
- match: |-
564582
(?x:
565583
(

Tests/syntax_test_PowerShell.ps1

+8-2
Original file line numberDiff line numberDiff line change
@@ -476,8 +476,14 @@ There is no @platting here!
476476
1.d
477477
# ^^^ constant.numeric.float
478478
1.lGB
479-
# ^^^ constant.numeric.float - unclear whether float or int
479+
# ^^^ invalid.deprecated
480480
# ^^ keyword.other.unit
481+
1.2345e1LGB
482+
# ^^^^^^^^^ invalid.deprecated
483+
# ^^ keyword.other.unit
484+
1.2345e-5LGB
485+
# ^^^^^^^^^^ invalid.deprecated
486+
# ^^ keyword.other.unit
481487
1.dGB
482488
# ^^^ constant.numeric.float
483489
# ^^ keyword.other.unit
@@ -524,7 +530,7 @@ There is no @platting here!
524530
# ^ keyword.operator
525531
-10.002L
526532
# ^ keyword.operator.unary
527-
# ^^^^^^^ constant.numeric.float - unclear whether float or int
533+
# ^^^^^^^ invalid.deprecated
528534
$x..5.40D
529535
# ^ punctuation.definition.variable
530536
# ^^ variable.other.readwrite

0 commit comments

Comments
 (0)