From 5eb8f717652ac3953ba48ee6ce72e90e38153146 Mon Sep 17 00:00:00 2001 From: "Olivier Wilkinson (reivilibre)" <oliverw@matrix.org> Date: Tue, 10 Oct 2023 14:30:35 +0100 Subject: [PATCH 1/4] Add reminder to check special release notes board in release script --- scripts-dev/release.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts-dev/release.py b/scripts-dev/release.py index 74f41a40ec77..76e7cddb87ed 100755 --- a/scripts-dev/release.py +++ b/scripts-dev/release.py @@ -684,6 +684,8 @@ def full(gh_token: str) -> None: click.echo("1. If this is a security release, read the security wiki page.") click.echo("2. Check for any release blockers before proceeding.") click.echo(" https://github.com/matrix-org/synapse/labels/X-Release-Blocker") + click.echo("3. Check for any other special release notes, including announcements to add to the changelog or special deployment instructions.") + click.echo(" https://github.com/orgs/matrix-org/projects/93/views/1") click.confirm("Ready?", abort=True) From 566e00111127980c9e628e00fad2a6933b61eb15 Mon Sep 17 00:00:00 2001 From: "Olivier Wilkinson (reivilibre)" <oliverw@matrix.org> Date: Tue, 10 Oct 2023 14:31:04 +0100 Subject: [PATCH 2/4] Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> --- changelog.d/16461.misc | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/16461.misc diff --git a/changelog.d/16461.misc b/changelog.d/16461.misc new file mode 100644 index 000000000000..96d040b74287 --- /dev/null +++ b/changelog.d/16461.misc @@ -0,0 +1 @@ +Update the release script to remind releaser to check for special release notes. \ No newline at end of file From 0ea4bf2313e0ab4a68cc46c05905269892378cf6 Mon Sep 17 00:00:00 2001 From: reivilibre <oliverw@matrix.org> Date: Fri, 13 Oct 2023 15:01:28 +0100 Subject: [PATCH 3/4] Update release.py --- scripts-dev/release.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts-dev/release.py b/scripts-dev/release.py index 76e7cddb87ed..e00fd143483f 100755 --- a/scripts-dev/release.py +++ b/scripts-dev/release.py @@ -685,7 +685,7 @@ def full(gh_token: str) -> None: click.echo("2. Check for any release blockers before proceeding.") click.echo(" https://github.com/matrix-org/synapse/labels/X-Release-Blocker") click.echo("3. Check for any other special release notes, including announcements to add to the changelog or special deployment instructions.") - click.echo(" https://github.com/orgs/matrix-org/projects/93/views/1") + click.echo(" See the 'Synapse Maintainer Report'.") click.confirm("Ready?", abort=True) From 897f6eb31a8ce5891ab7e891332b2ae8e47f7054 Mon Sep 17 00:00:00 2001 From: "Olivier Wilkinson (reivilibre)" <oliverw@matrix.org> Date: Fri, 13 Oct 2023 15:04:11 +0100 Subject: [PATCH 4/4] Bah, black --- scripts-dev/release.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts-dev/release.py b/scripts-dev/release.py index e00fd143483f..7508ae509625 100755 --- a/scripts-dev/release.py +++ b/scripts-dev/release.py @@ -684,7 +684,9 @@ def full(gh_token: str) -> None: click.echo("1. If this is a security release, read the security wiki page.") click.echo("2. Check for any release blockers before proceeding.") click.echo(" https://github.com/matrix-org/synapse/labels/X-Release-Blocker") - click.echo("3. Check for any other special release notes, including announcements to add to the changelog or special deployment instructions.") + click.echo( + "3. Check for any other special release notes, including announcements to add to the changelog or special deployment instructions." + ) click.echo(" See the 'Synapse Maintainer Report'.") click.confirm("Ready?", abort=True)