Skip to content

[Issue] Fixed conflicting styles for product image container in different listings at the same page #35372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 5 tasks
m2-assistant bot opened this issue Apr 26, 2022 · 1 comment
Closed
1 of 5 tasks

[Issue] Fixed conflicting styles for product image container in different listings at the same page #35372

m2-assistant bot opened this issue Apr 26, 2022 · 1 comment
Labels
Component: Catalog Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Apr 26, 2022

This issue is automatically created based on existing pull request: #31473: Fixed conflicting styles for product image container in different listings at the same page

Description (*)

This pull requests solves problem when there are two product listing blocks on the same page. Both blocks have at list one common product. And listings have different image sizes for product image.

Related Pull Requests

Can't find related pull requests.

Fixed Issues (if relevant)

Can't find related issue.

Manual testing scenarios (*)

  1. Open product "Crown Summit Backpack" (SKU 24-MB03) to assign up-sell products. Add at list one up-sell product. One of the assigned products must be "Fusion Backpack" (SKU 24-MB02). Save changes.
  2. Create widget "Catalog Product List" via Magento Admin. Assign widget to store view you test. Layout updates settings: display on "Specified page"; page "Catalog Product View"; container "Main Content Top". Widget Options - select at least two product via SKU. One of products must be "Fusion Backpack" (SKU 24-MB02). Save widget.
  3. Clear Magento 2 cache.
  4. Open product page for "Crown Summit Backpack" (SKU 24-MB03) at store front.

image

With old code you can see that "Fusion Backpack" has smaller image than it should.

This pull request fixes it. "Fusion Backpack" will get same size as "Affirm Water Bottle".

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fixed conflicting styles for product image container in different listings at the same page #31526: Fixed conflicting styles for product image container in different listings at the same page
@m2-assistant m2-assistant bot added Component: Catalog Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Apr 26, 2022
@m2-assistant m2-assistant bot mentioned this issue Apr 26, 2022
Closed
6 tasks
@engcom-Charlie
Copy link
Contributor

Closing this issue as it is duplicate of #31526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Catalog Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
High Priority Backlog
Archived in project
Milestone
No milestone
1 participant
@engcom-Charlie