Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some C functions have return values for no (apparently) good reason #2

Open
d-lamb opened this issue Jan 11, 2016 · 0 comments
Open
Labels

Comments

@d-lamb
Copy link
Collaborator

d-lamb commented Jan 11, 2016

There are several C functions that modify a world or a fluxon or a vertex by getting a pointer to that object. And then they return '0' always. It is not clear whether this is intentional--are the 0's used as status checks?--or accidental.

To find these instances do:

cd lib
grep --exclude='*.cf.c' 'return 0;' *

If these return values are never used then probably the return value should be dropped and the functions changed to void return type instead of int, long, or NUM.

d-lamb pushed a commit that referenced this issue May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant