Upgrade to latest @stacks/wallet-sdk

[kyranjamie]

We need to upgrade the wallet-sdk to the version including @friedger's PR hirosystems/stacks.js#1204

This will fix profile signing for new users

cc/ @markmhx @pradel

[pradel]

To add to the context, I saw that a commit with 3.4.0 release was created but I couldn't find the tag on npm so maybe something went wrong during the release process.

[fbwoolf]

Will need to address this when we do the update: #2282

[markmhendrickson]

@kyranjamie @pradel Can one of you spell out the exact problem that will or does occur already without this upgrade, so that we capture clearly here the specific UX benefit to this upgrade?

[pradel]

This fix is for signing the profile.json with the right key, no UX changes are required.

[markmhendrickson]

I mean to ask, what UX problems will occur if we don't make this upgrade (aside from us needing to make any UX changes per se, since I agree those aren't required)?

In other words, what will go wrong exactly (e.g. with Sigle usage) if we don't upgrade how the profile.json is signed? I presume something akin to what we outlined here in Notion, but would like to capture here on GitHub as well.

[pradel]

From the notion, the part not working is:

• Accounts displayed all the same as before
• Others attempting to view sigle.io/mary.id.blockstack/mypost can view her blog post
• Others attempting to view sigle.io/mary1.btc/mypost cannot view her blog post

The profile.json is signed with the wrong key, so when we fetch the profile we can't verify that mary1.btc did sign it properly.

[timstackblock]

.btc names still do not work with the latest version of the app https://sigle-git-feature-stacks-wallet-extension-sigle.vercel.app/

Ran a test with a regular ID it works fine.
Then ran a test with my .btc username and it wont allow you into the app

VIDEO of the issue
https://somup.com/c3evqbOVTC

cc @Eshwari007 @markmhx

[andresgalante]

@Eshwari007 can you please test this issue with a .btc name?

[Eshwari007]

Test findings

Tested the PR on https://sigle-git-feature-stacks-wallet-extension-sigle.vercel.app/login
Test failed, I was not able to login and notice errors in console log
Attaching the screenshots for perusal

cc @andresgalante @markmhx @pradel

[andresgalante]

Thanks @Eshwari007 🙇 @pradel @beguene what are the next steps?

[beguene]

@andresgalante Not sure about the next steps. In this PR I fixed the unit tests errors but I did not touch the profile signing issue maybe @pradel Can give more details.

[pradel]

@beguene @andresgalante @Eshwari007 I will have to look next week what's going on.

But looks like I can't login anymore using an account with a .btc domain with the latest 3.7.0 version. I tried on Arkadiko, Alex and Frens. So the issue you faced might not be related to the changes?

[pradel]

Created a separate issue #2354

[markmhendrickson]

I believe we need to upgrade Stacks.js for the test app to include the changes made with hirosystems/stacks.js#1230 then retest the related PR.

@janniks can confirm if that's indeed the case here given the case encountered above during testing before.

[andresgalante]

Waiting for the test app to update stackjs to be QAed