Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix incorrect import path for create_retrieval_chain in documentation #29560 #29562

Closed
wants to merge 1 commit into from

Conversation

jasminaaa20
Copy link

Thank you for contributing to LangChain!

  • PR title: "docs: Fix incorrect import path for create_retrieval_chain in documentation"

  • PR message:

  • Add tests and docs:

    • No new tests required, as this is a documentation fix.
  • Lint and test:

    • Ran make format, make lint, and make test to ensure compliance with contribution guidelines.

This is a small but important fix to improve the accuracy of LangChain’s documentation. Looking forward to the review! 🚀

Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 4:44pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Feb 3, 2025
Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. create_retrieval_chain is deliberately exported from langchain.chains:

"create_retrieval_chain": "langchain.chains.retrieval",

I can't reproduce the error.

@ccurme ccurme closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

DOC: Incorrect Import Path for create_retrieval_chain in Documentation Example
2 participants