Nginx vts as prometheus metrics

[gianrubio]

Currently the nginx endpoint for metrics only support vts metric, that provide html and json metrics.
I figured out a project that export vts metrics to prometheus, now I have all metrics, simply using a sidecar container pointing to vts. Here's my awesome metrics.

I'm interested in porting this for the nginx ingress, but first I'm here to ask if this is in the roadmap or if anyone is already working on this.

[aledbf]

@gianrubio prometheus metrics are already present in master (only for standard nginx, not vts). Please check #36
Maybe you can open a PR to extract the metrics from the vts module?

[gianrubio]

@aledbf you are wright, there's an endpoint for global nginx metrics.
I can do this PR, what dou you think is the better way to do this?

1 - Create another endpoint for metrics
2 - Merge this vts metrics with global
3 - Run a sidecar container extracting vts metrics?

[aledbf]

2 - Merge this vts metrics with global

[cmluciano]

@gianrubio Are you still interested in working on this?

[gianrubio]

yes @cmluciano, I'm working on this, 70% is done. Give me more 2 days and I'll submit this PR

[hartmut-pq]

Hi, been reading cross many issues, PRs, .. unsure if I should open a separate issue or not..

Are there any plans to add metrics from https://github.com/hnlq715/nginx-vts-exporter ?

mostly interested in

{NAMESPACE}_server_requests | code [2xx, 3xx, 4xx, 5xx, total], host (or domain name)

[gianrubio]

@harmut-pq take a look on this config https://github.com/kubernetes/ingress/blob/master/examples/customization/custom-vts-metrics/nginx/nginx-vts-metrics-conf.yaml
If this didn't help you, please open a new issue and relate to me

[hartmut-pq]

Hi @gianrubio, thanks for the hint!
This configuration enabled some more vts metrics - can't find any response codes though. Is this supported in any way?