Skip to content

Commit 6895e71

Browse files
committed
Fix e2e make targets
1 parent ac6930b commit 6895e71

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

.travis.yml

-1
Original file line numberDiff line numberDiff line change
@@ -30,5 +30,4 @@ before_script:
3030

3131
script:
3232
- make fmt lint vet cover
33-
#- make controllers controllers-images
3433
#- make test-e2e

Makefile

+6-2
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,14 @@ clean:
5959
controllers:
6060
make -C controllers/nginx build
6161

62-
.PHONY: controllers-images
63-
controllers-images:
62+
.PHONY: docker-build
63+
docker-build: controllers
6464
make -C controllers/nginx container
6565

66+
.PHONY: docker-push
67+
docker-push: docker-build
68+
make -C controllers/nginx push
69+
6670
.PHONY: ginkgo
6771
ginkgo:
6872
go get github.com/onsi/ginkgo/ginkgo

hack/e2e.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ func validWorkingDirectory() error {
5757
if err != nil {
5858
return fmt.Errorf("failed to convert %s to an absolute path: %v", cwd, err)
5959
}
60-
if !strings.Contains(filepath.Base(acwd), "ingress-controller") {
60+
if !strings.Contains(filepath.Base(acwd), "ingress") {
6161
return fmt.Errorf("must run from git root directory: %v", acwd)
6262
}
6363
return nil
@@ -214,7 +214,7 @@ func run(deploy deployer) error {
214214
func Build() error {
215215
// The build-release script needs stdin to ask the user whether
216216
// it's OK to download the docker image.
217-
cmd := exec.Command("make", "backends", "backends-images", "backends-push")
217+
cmd := exec.Command("make", "docker-build", "docker-push")
218218
cmd.Stdin = os.Stdin
219219
if err := finishRunning("build-release", cmd); err != nil {
220220
return fmt.Errorf("error building: %v", err)

0 commit comments

Comments
 (0)