Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restaurant Site Linking #102

Open
avatarneil opened this issue Nov 21, 2020 · 2 comments
Open

Restaurant Site Linking #102

avatarneil opened this issue Nov 21, 2020 · 2 comments

Comments

@avatarneil
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
I think a primary use-case could be picking restaurants you've never been to before! While the app can certainly enables this currently; I think it can do a better job. Menu information not being accessible from the application is a bit limiting.

Describe the solution you'd like
To start, it would be great if we could link to the restaurant's site. Ought to be pretty easy to add a link to the restaurant site that Yelp provides, and if Yelp doesn't have a site entry then link to a google search instead.

Describe alternatives you've considered
Either embed the restaurant's menu, or link directly to a menu on their site. Trying to access the menu directly would almost certainly prove to be a rabbit hole though, as many restaurants have differing data formats for their menus, and to the best of my knowledge there's no free DB we can query for menu PDFs. I think it's just easier to provide a link to the restaurant's main page, for now.

@kelvinfan001
Copy link
Owner

kelvinfan001 commented Nov 22, 2020

Thanks for submitting this! Definitely tons of room for improvement regarding the info on the restaurant cards.

Just to note though, we do currently link to the Yelp site in the Match popup. But IIUC this issue is meant to add the the actual restaurant site link, right? Are you thinking of linking to both Yelp and restaurant site? Or replace the Yelp link with the restaurant link? Either way, a link to the actual restaurant site would be really helpful.

We should also think about making it more intuitive/obvious to users that tapping on the restaurant photo in the match popup links to Yelp/restaurant site, but perhaps we should create a separate issue for this.

@avatarneil
Copy link
Collaborator Author

Haha, so I didn't even realize that we linked to the Yelp site currently! Haven't dug into the Match card component yet. We definitely should make that more discoverable, and I think another issue would be useful for that. But yeah, this issue is primarily focused around linking to the actual restaurant's site as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants