-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ExtensionApp] "standalone" mode #64
Comments
Another option would be to have each extension app decide whether they allow other server extensions or not when they are used as the main extension point. |
I thought that the selected app is responsible for enabling all extensions that should be running, besides the default stuff that comes with Jupyter Server itself. So if the Voila extension doesn't enable Lab, then Lab isn't there. Am I mistaken there? |
Just for context, what is the motivation for this? |
This would reduce the number of entry points and simplify the codebase (e.g. no need for a VoilaConfiguration object). |
In a way, voila and lab are two perfect examples of extension apps... |
In the current In PR #59, I added logic to handle the extension-specific config. That way, extensions writers don't need to write their own mixin classes (like VoilaConfiguration). How does this work?
|
I'm also fine with adding a |
Yep, but I guess this requires the voila command line to be an alias on
👍 |
I think you're right. You could, instead, have a small subclass that inherits the |
Adding in #70 |
We added the option for ExtensionApps to shut off other extensions in #76 |
Closing since we added standalone mode in #76. |
* port JWT authenticator/handler to this repo * thread authentication traits throughout app * add aliases for simple help docs * use inherited config for comon config * enable JWT authentication * working tests * enable nbclassic/lab
I was looking at the extension app mechanism, and I have some thoughts for the
voila
use case.Ideally, I would like to have the
voila
command line to become an alias onjupyter voila
. A byproduct will be that we should be able to drop theVoilaConfiguration
mixin used by both the tornado application and the server extension...Now, one thing about the voila command line that we would lose, is the guarantee that other server extensions are not enabled. The reason is that we generally want
voila
to be used to produce standalone web app that don't allow arbitrary code execution. Enabling thelab
server extension defeats the purpose, because it would provide a means to access and execute code...So an idea would be to have a
--standalone
option that only enables the selected server extension and not the other ones. Thenvoila
would make use ofjupyter voila --standalone
...cc @rolweber @Zsailer @epifanio
The text was updated successfully, but these errors were encountered: