xCluster: Fixed random problem with tests failing (dsccommunity#134)

- Changes to xCluster
  - Fixed random problem with tests failing with error "Invalid token for
    impersonation - it cannot be duplicated." (issue dsccommunity#133).

Author: johlju

CHANGELOG.md

@@ -35,6 +35,8 @@
     etc.
   - Enabled localization for all strings ([issue #83](https://github.com/PowerShell/xFailOverCluster/issues/83)).
   - Added tests to improve code coverage.
+    - Fixed random problem with tests failing with error "Invalid token for
+      impersonation - it cannot be duplicated." ([issue #133](https://github.com/PowerShell/xFailOverCluster/issues/133)).
 - Changes to xWaitForCluster
   - Refactored the unit test for this resource to use stubs and increase coverage
     ([issue #78](https://github.com/PowerShell/xFailOverCluster/issues/78)).

Tests/Unit/MSFT_xCluster.Tests.ps1

@@ -104,6 +104,19 @@ try
             )
         }
 
+        $mockNewObjectWindowsIdentity = {
+            return [PSCustomObject] @{} |
+                Add-Member -MemberType ScriptMethod -Name Impersonate -Value {
+                    return [PSCustomObject] @{} |
+                        Add-Member -MemberType ScriptMethod -Name Undo -Value {} -PassThru |
+                        Add-Member -MemberType ScriptMethod -Name Dispose -Value {} -PassThru -Force
+                } -PassThru -Force
+        }
+
+        $mockNewObjectWindowsIdentity_ParameterFilter = {
+            $TypeName -eq 'Security.Principal.WindowsIdentity'
+        }
+
         $mockDefaultParameters = @{
             Name                          = $mockClusterName
             StaticIPAddress               = $mockStaticIpAddress
@@ -140,6 +153,8 @@ try
                 Mock -CommandName Add-Type -MockWith {
                     return $mockLibImpersonationObject
                 }
+
+                Mock -CommandName New-Object -MockWith $mockNewObjectWindowsIdentity -ParameterFilter $mockNewObjectWindowsIdentity_ParameterFilter -Verifiable
             }
 
             Context 'When the computers domain name cannot be evaluated' {
@@ -194,6 +209,14 @@ try
         }
 
         Describe 'xCluster\Set-TargetResource' {
+            BeforeAll {
+                Mock -CommandName Add-Type -MockWith {
+                    return $mockLibImpersonationObject
+                }
+
+                Mock -CommandName New-Object -MockWith $mockNewObjectWindowsIdentity -ParameterFilter $mockNewObjectWindowsIdentity_ParameterFilter -Verifiable
+            }
+
             Context 'When computers domain name cannot be evaluated' {
                 It 'Should throw the correct error message' {
                     $mockDynamicDomainName = $null
@@ -339,6 +362,14 @@ try
         }
 
         Describe 'xCluster\Test-TargetResource' {
+            BeforeAll {
+                Mock -CommandName Add-Type -MockWith {
+                    return $mockLibImpersonationObject
+                }
+
+                Mock -CommandName New-Object -MockWith $mockNewObjectWindowsIdentity -ParameterFilter $mockNewObjectWindowsIdentity_ParameterFilter -Verifiable
+            }
+
             Context 'When computers domain name cannot be evaluated' {
                 It 'Should throw the correct error message' {
                     $mockDynamicDomainName = $null