From e32b54e8e27940afbc2d3140ed5dac40cc608d0c Mon Sep 17 00:00:00 2001 From: Patrick Hopfner Date: Wed, 2 May 2018 16:11:50 +0200 Subject: [PATCH 1/2] jest-message-util: don't exclude trace lines anymore --- CHANGELOG.md | 2 ++ .../__snapshots__/messages.test.js.snap | 18 ++++++++++ .../src/__tests__/messages.test.js | 34 +++++++++++++++++++ packages/jest-message-util/src/index.js | 2 +- 4 files changed, 55 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 335f3926ea70..85c951d54ed0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,8 @@ ### Features +* `[jest-message-util]` Don't ignore messages with `vendor` anymore + ([#XXXX](https://github.com/facebook/jest/pull/XXXX)) * `[jest-validate]` Get rid of `jest-config` dependency ([#6067](https://github.com/facebook/jest/pull/6067)) * `[jest-validate]` Adds option to inject `deprecationEntries` diff --git a/packages/jest-message-util/src/__tests__/__snapshots__/messages.test.js.snap b/packages/jest-message-util/src/__tests__/__snapshots__/messages.test.js.snap index b4ebdf847fe3..07a328bd79b2 100644 --- a/packages/jest-message-util/src/__tests__/__snapshots__/messages.test.js.snap +++ b/packages/jest-message-util/src/__tests__/__snapshots__/messages.test.js.snap @@ -33,3 +33,21 @@ exports[`should exclude jasmine from stack trace for Unix paths. 1`] = ` at Object.it (build/__tests__/messages-test.js:45:41) " `; + +exports[`should not exclude vendor from stack trace 1`] = ` +" Vendor test + + + Expected value to be of type: + \\"number\\" + Received: + \\"\\" + type: + \\"string\\" + + + at Object.it (__tests__/vendor/cool_test.js:6:666) + at Object.asyncFn (__tests__/vendor/sulu/node_modules/sulu-content-bundle/best_component.js:1:5) + +" +`; diff --git a/packages/jest-message-util/src/__tests__/messages.test.js b/packages/jest-message-util/src/__tests__/messages.test.js index 98ab8beab662..a148da84b339 100644 --- a/packages/jest-message-util/src/__tests__/messages.test.js +++ b/packages/jest-message-util/src/__tests__/messages.test.js @@ -44,6 +44,20 @@ const assertionStack = at internal/process/next_tick.js:188:7 `; +const vendorStack = + ' ' + + ` + Expected value to be of type: + "number" + Received: + "" + type: + "string" + + at Object.it (__tests__/vendor/cool_test.js:6:666) + at Object.asyncFn (__tests__/vendor/sulu/node_modules/sulu-content-bundle/best_component.js:1:5) +`; + it('should exclude jasmine from stack trace for Unix paths.', () => { const messages = formatResultsErrors( [ @@ -103,3 +117,23 @@ it('formatStackTrace should strip node internals', () => { expect(messages).toMatchSnapshot(); }); + +it('should not exclude vendor from stack trace', () => { + const messages = formatResultsErrors( + [ + { + ancestorTitles: [], + failureMessages: [vendorStack], + title: 'Vendor test', + }, + ], + { + rootDir: '', + }, + { + noStackTrace: false, + }, + ); + + expect(messages).toMatchSnapshot(); +}); diff --git a/packages/jest-message-util/src/index.js b/packages/jest-message-util/src/index.js index 7b7767116a0b..f9fad8f394c2 100644 --- a/packages/jest-message-util/src/index.js +++ b/packages/jest-message-util/src/index.js @@ -48,7 +48,7 @@ const PATH_NODE_MODULES = `${path.sep}node_modules${path.sep}`; const PATH_JEST_PACKAGES = `${path.sep}jest${path.sep}packages${path.sep}`; // filter for noisy stack trace lines -const JASMINE_IGNORE = /^\s+at(?:(?:.*?vendor\/|jasmine\-)|\s+jasmine\.buildExpectationResult)/; +const JASMINE_IGNORE = /^\s+at(?:(?:.jasmine\-)|\s+jasmine\.buildExpectationResult)/; const JEST_INTERNALS_IGNORE = /^\s+at.*?jest(-.*?)?(\/|\\)(build|node_modules|packages)(\/|\\)/; const ANONYMOUS_FN_IGNORE = /^\s+at .*$/; const ANONYMOUS_PROMISE_IGNORE = /^\s+at (new )?Promise \(\).*$/; From 1852927d683525c70049bacb6489bc89d8c106bc Mon Sep 17 00:00:00 2001 From: Patrick Hopfner Date: Wed, 2 May 2018 16:12:52 +0200 Subject: [PATCH 2/2] Add PR number --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 85c951d54ed0..f54f01397e32 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,7 +3,7 @@ ### Features * `[jest-message-util]` Don't ignore messages with `vendor` anymore - ([#XXXX](https://github.com/facebook/jest/pull/XXXX)) + ([#6117](https://github.com/facebook/jest/pull/6117)) * `[jest-validate]` Get rid of `jest-config` dependency ([#6067](https://github.com/facebook/jest/pull/6067)) * `[jest-validate]` Adds option to inject `deprecationEntries`