Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use jest-matchers/src/extractExpectedAssertionsErrors.js in jasmine setup #3820

Closed
aaronabramov opened this issue Jun 14, 2017 · 2 comments
Closed

use jest-matchers/src/extractExpectedAssertionsErrors.js in jasmine setup #3820

aaronabramov opened this issue Jun 14, 2017 · 2 comments
Labels
good first issue

Comments

@aaronabramov
Copy link
Contributor

aaronabramov commented Jun 14, 2017 •
edited
Loading

We're in the process of replacing Jasmine with our own framework jest-circus

during this process we had to duplicate some logic and now we have almost the same code in two places.
(the code that implements this feature)

We need to replace this code with a function that calls this module instead
liubinyi added a commit to liubinyi/jest that referenced this issue Jun 17, 2017
@liubinyi
Fixes jestjs#3820 use extractExpectedAssertionsErrors in jasmine setup
5e923da
@liubinyi liubinyi mentioned this issue Jun 17, 2017
Closed
liubinyi added a commit to liubinyi/jest that referenced this issue Jun 17, 2017
@liubinyi
Fixes jestjs#3820
3b5f608
@liubinyi liubinyi mentioned this issue Jun 17, 2017
Closed
@liubinyi
Copy link
Contributor

@DmitriiAbramov pr sent. sorry about the messy commit history. i forgot to pull master. please let me know if you find any issues. Thanks!

aaronabramov pushed a commit to aaronabramov/jest that referenced this issue Jun 21, 2017
@liubinyi @aaronabramov
Fixes jestjs#3820 use extractExpectedAssertionsErrors in jasmine setup
74cf7ba
aaronabramov pushed a commit to aaronabramov/jest that referenced this issue Jun 21, 2017
@liubinyi @aaronabramov
Fixes jestjs#3820 use extractExpectedAssertionsErrors in jasmine setup
b476ecc 
remove cleanupStackTrace

remove obsolete

update code according to comments

revert snap test change

update for review
tushardhole pushed a commit to tushardhole/jest that referenced this issue Aug 21, 2017
@liubinyi @aaronabramov
Fixes jestjs#3820 use extractExpectedAssertionsErrors in jasmine setup
6b7c3f3 
remove cleanupStackTrace

remove obsolete

update code according to comments

revert snap test change

update for review
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use extractExpectedAssertionsErrors in jasmine liubinyi/jest
2 participants
@aaronabramov @liubinyi