Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromium memory leak? #544

Closed
SesioN opened this issue Oct 19, 2020 · 5 comments
Closed

Chromium memory leak? #544

SesioN opened this issue Oct 19, 2020 · 5 comments

Comments

@SesioN
Copy link
Contributor

SesioN commented Oct 19, 2020

Description

I'm running your nvidia-snatcher together with #534 and INCOGNITO=true.
I've noticed that the (main?) chrome process keeps constantly growing in memory usage. Yesterday there was a crash at some point but I sadly by mistake overwrote the logs files that contained details regarding that.

But I somehow doubt that the issue is within nvidia-snatcher or even puppeteer.
I would assume that this is a chromium leak but I figured to ask for your opinion just to ensure that we can rule out nvidia-snatcher.

OS: Ubuntu 20.04 Linux unknown 5.4.0-48-generic #52-Ubuntu SMP Thu Sep 10 10:58:49 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Chromium: 86.0.4240.75 snap
memoryLeak

Possible solution

@Mad1723
Copy link

Mad1723 commented Oct 19, 2020

I have experienced the same. The script ends up loading my 32GB of memory fully after a day or 2 of running.

@jef
Copy link
Owner

jef commented Oct 19, 2020

Yep. Same within Docker. Probably a browser/tab not getting closed in a certain mode. Will look into soon.

@Sethtrosity
Copy link
Contributor

Sethtrosity commented Oct 20, 2020

I'm not sure if the issue is related to closing the incognito BrowserContext, but I forgot to include the following:

await context.close();

Seems to be an old problem, see Here

@SesioN
Copy link
Contributor Author

SesioN commented Oct 20, 2020

@GRINSPANKER13
It seems that it was indeed the missing context.close(), after adding that to the code the memory leak seems to be gone.

@SesioN SesioN closed this as completed Oct 20, 2020
@jef
Copy link
Owner

jef commented Oct 20, 2020

Sweet! Thank you very much @GRINSPANKER13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants