go.mod is ignored

[tetienne]

According to the documentation, mise should be able to read the go version within go.mod.

# go.mod
...
go 1.23.4
...

install command does not detect anything.

❯ mise install
mise all runtimes are installed

and mise use go install the latest version.

[tools]
go = "latest"

Am I missing something?

[jdx]

seems this was missed when the core tool was written, it's not hard to do, someone could reference the ruby plugin which does similar work with Gemfile:

mise/src/plugins/core/ruby.rs

Lines 374 to 399 in 6ccb1d9

	fn parse_gemfile(body: &str) -> String {
	let v = body
	.lines()
	.find(|line| line.trim().starts_with("ruby "))
	.unwrap_or_default()
	.trim()
	.split('#')
	.next()
	.unwrap_or_default()
	.replace("engine:", ":engine =>")
	.replace("engine_version:", ":engine_version =>");
	let v = regex!(r#".*:engine *=> *['"](?<engine>[^'"]*).*:engine_version *=> *['"](?<engine_version>[^'"]*).*"#).replace_all(&v, "${engine_version}__ENGINE__${engine}").to_string();
	let v = regex!(r#".*:engine_version *=> *['"](?<engine_version>[^'"]*).*:engine *=> *['"](?<engine>[^'"]*).*"#).replace_all(&v, "${engine_version}__ENGINE__${engine}").to_string();
	let v = regex!(r#" *ruby *['"]([^'"]*).*"#)
	.replace_all(&v, "$1")
	.to_string();
	let v = regex!(r#"^[^0-9]"#).replace_all(&v, "").to_string();
	let v = regex!(r#"(.*)__ENGINE__(.*)"#)
	.replace_all(&v, "$2-$1")
	.to_string();
	// make sure it's like "ruby-3.0.0" or "3.0.0"
	if !regex!(r"^(\w+-)?([0-9])(\.[0-9])*$").is_match(&v) {
	return "".to_string();
	}
	v
	}

[tetienne]

@jdx Would you accept a PR about this?

[roele]

created a PR for this at #4312

[alock]

Is there an option to disable this new addition?

The go directive within go.mod is meant to be the minimum-go-version according to their documentation.

The current behavior is forcing me to always install the minimal version, even though the project will still work on latest (or a newer version than defined in the directive).

[roele]

This can be disabled with idiomatic_version_file_disable_tools = ["go"] (see idiomatic_version_file_disable_tools).

This setting is discussed to be changed in #4345.

[jdx]

@alock is correct though, I didn't realize this is for minimum compatible version which should not be used for idiomatic files

[roele]

Did not realize this either. Maybe that was the reason this was not implemented in the first place. Unfortunately we don't have a scope supporting such behaviour. Should we revert and remove this from the docs instead?

[tetienne]

If we decide not to read the go.mod version, I think we should explicitly document the reason. So it will avoid subject like mine.