Skip to content

Commit 40824e1

Browse files
coeuvrecopybara-github
authored andcommitted
Update rbe config to pick up JDK21
PiperOrigin-RevId: 614590443 Change-Id: I480373360786330d2ade3a916b92261f4e2c91b4
1 parent 86d0a10 commit 40824e1

7 files changed

+46
-38
lines changed

.bazelci/postsubmit.yml

+10-9
Original file line numberDiff line numberDiff line change
@@ -320,28 +320,34 @@ tasks:
320320
rbe_ubuntu2004:
321321
platform: ubuntu2004
322322
name: "RBE"
323+
environment:
324+
# Use last_green to pickup the fix for https://github.com/bazelbuild/bazel/issues/21604.
325+
# TODO(chiwang): Remove this after Bazel 7.2.0 is released.
326+
USE_BAZEL_VERSION: last_green
323327
shell_commands:
324328
- sed -i.bak
325329
-e 's/^# android_sdk_repository/android_sdk_repository/'
326330
-e 's/^# android_ndk_repository/android_ndk_repository/' WORKSPACE.bzlmod
327331
- rm -f WORKSPACE.bzlmod.bak
328332
build_flags:
329-
- "--config=ubuntu2004_java11"
333+
- "--config=remote"
330334
- "--remote_executor=grpcs://remotebuildexecution.googleapis.com"
331335
- "--jobs=200"
332336
- "--experimental_remote_cache_async"
333-
- "--experimental_remote_merkle_tree_cache"
337+
# https://github.com/bazelbuild/bazel/issues/21628
338+
# - "--experimental_remote_merkle_tree_cache"
334339
- "--remote_download_minimal"
335340
build_targets:
336341
- "//src:bazel"
337342
- "//src:bazel_jdk_minimal"
338343
- "//src/main/java/..."
339344
test_flags:
340-
- "--config=ubuntu2004_java11"
345+
- "--config=remote"
341346
- "--remote_executor=grpcs://remotebuildexecution.googleapis.com"
342347
- "--jobs=200"
343348
- "--experimental_remote_cache_async"
344-
- "--experimental_remote_merkle_tree_cache"
349+
# https://github.com/bazelbuild/bazel/issues/21628
350+
# - "--experimental_remote_merkle_tree_cache"
345351
- "--remote_download_minimal"
346352
test_targets:
347353
- "//scripts/..."
@@ -371,11 +377,6 @@ tasks:
371377
- "-//src/test/py/bazel:bzlmod_query_test"
372378
- "-//src/test/py/bazel:mod_command_test"
373379
- "-//src/test/shell/bazel:verify_workspace"
374-
# TODO(pcloudy): Re-enable after rbe platform switch to JDK 21
375-
- "-//src/java_tools/junitrunner/javatests/com/google/testing/junit/runner:AllTests"
376-
- "-//src/java_tools/junitrunner/javatests/com/google/testing/junit/runner:antxmlresultwriter_integration_test"
377-
- "-//src/java_tools/junitrunner/javatests/com/google/testing/junit/runner:junit4_testbridge_integration_test"
378-
- "-//src/java_tools/junitrunner/javatests/com/google/testing/junit/runner:utf8_test_log_test"
379380
include_json_profile:
380381
- build
381382
- test

.bazelci/presubmit.yml

+10-9
Original file line numberDiff line numberDiff line change
@@ -378,28 +378,34 @@ tasks:
378378
rbe_ubuntu2004:
379379
platform: ubuntu2004
380380
name: "RBE"
381+
environment:
382+
# Use last_green to pickup the fix for https://github.com/bazelbuild/bazel/issues/21604.
383+
# TODO(chiwang): Remove this after Bazel 7.2.0 is released.
384+
USE_BAZEL_VERSION: last_green
381385
shell_commands:
382386
- sed -i.bak
383387
-e 's/^# android_sdk_repository/android_sdk_repository/'
384388
-e 's/^# android_ndk_repository/android_ndk_repository/' WORKSPACE.bzlmod
385389
- rm -f WORKSPACE.bzlmod.bak
386390
build_flags:
387-
- "--config=ubuntu2004_java11"
391+
- "--config=remote"
388392
- "--remote_executor=grpcs://remotebuildexecution.googleapis.com"
389393
- "--jobs=200"
390394
- "--experimental_remote_cache_async"
391-
- "--experimental_remote_merkle_tree_cache"
395+
# https://github.com/bazelbuild/bazel/issues/21628
396+
# - "--experimental_remote_merkle_tree_cache"
392397
- "--remote_download_minimal"
393398
build_targets:
394399
- "//src:bazel"
395400
- "//src:bazel_jdk_minimal"
396401
- "//src/main/java/..."
397402
test_flags:
398-
- "--config=ubuntu2004_java11"
403+
- "--config=remote"
399404
- "--remote_executor=grpcs://remotebuildexecution.googleapis.com"
400405
- "--jobs=200"
401406
- "--experimental_remote_cache_async"
402-
- "--experimental_remote_merkle_tree_cache"
407+
# https://github.com/bazelbuild/bazel/issues/21628
408+
# - "--experimental_remote_merkle_tree_cache"
403409
- "--remote_download_minimal"
404410
test_targets:
405411
- "//scripts/..."
@@ -432,11 +438,6 @@ tasks:
432438
# Flaky on rbe_ubuntu2004
433439
# https://github.com/bazelbuild/continuous-integration/issues/1631
434440
- "-//src/test/shell/bazel:bazel_sandboxing_networking_test"
435-
# TODO(pcloudy): Re-enable after rbe platform switch to JDK 21
436-
- "-//src/java_tools/junitrunner/javatests/com/google/testing/junit/runner:AllTests"
437-
- "-//src/java_tools/junitrunner/javatests/com/google/testing/junit/runner:antxmlresultwriter_integration_test"
438-
- "-//src/java_tools/junitrunner/javatests/com/google/testing/junit/runner:junit4_testbridge_integration_test"
439-
- "-//src/java_tools/junitrunner/javatests/com/google/testing/junit/runner:utf8_test_log_test"
440441
include_json_profile:
441442
- build
442443
- test

.bazelrc

+8-8
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,16 @@ build:remote_shared --java_runtime_version=rbe_jdk
1212
build:remote_shared --tool_java_runtime_version=rbe_jdk
1313

1414
# Configuration to build and test Bazel on RBE on Ubuntu 18.04 with Java 11
15-
build:ubuntu2004_java11 --extra_toolchains=@rbe_ubuntu2004_java11//java:all
16-
build:ubuntu2004_java11 --crosstool_top=@rbe_ubuntu2004_java11//cc:toolchain
17-
build:ubuntu2004_java11 --extra_toolchains=@rbe_ubuntu2004_java11//config:cc-toolchain
18-
build:ubuntu2004_java11 --extra_execution_platforms=//:rbe_ubuntu2004_java11_platform,//:rbe_ubuntu2004_java11_highcpu_platform
19-
build:ubuntu2004_java11 --host_platform=//:rbe_ubuntu2004_java11_platform
20-
build:ubuntu2004_java11 --platforms=//:rbe_ubuntu2004_java11_platform
21-
build:ubuntu2004_java11 --config=remote_shared
15+
build:ubuntu2004 --extra_toolchains=@rbe_ubuntu2004//java:all
16+
build:ubuntu2004 --crosstool_top=@rbe_ubuntu2004//cc:toolchain
17+
build:ubuntu2004 --extra_toolchains=@rbe_ubuntu2004//config:cc-toolchain
18+
build:ubuntu2004 --extra_execution_platforms=//:rbe_ubuntu2004_platform,//:rbe_ubuntu2004_highcpu_platform
19+
build:ubuntu2004 --host_platform=//:rbe_ubuntu2004_platform
20+
build:ubuntu2004 --platforms=//:rbe_ubuntu2004_platform
21+
build:ubuntu2004 --config=remote_shared
2222

2323
# Alias
24-
build:remote --config=ubuntu2004_java11
24+
build:remote --config=ubuntu2004
2525

2626
build:macos --macos_minimum_os=10.11
2727

BUILD

+1-1
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ platform(
282282
],
283283
)
284284

285-
REMOTE_PLATFORMS = ("rbe_ubuntu2004_java11",)
285+
REMOTE_PLATFORMS = ("rbe_ubuntu2004",)
286286

287287
[
288288
platform(

MODULE.bazel

+1-1
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ use_repo(
311311
)
312312

313313
bazel_rbe_deps = use_extension("//:rbe_extension.bzl", "bazel_rbe_deps")
314-
use_repo(bazel_rbe_deps, "rbe_ubuntu2004_java11")
314+
use_repo(bazel_rbe_deps, "rbe_ubuntu2004")
315315

316316
remote_coverage_tools_extension = use_extension("//tools/test:extensions.bzl", "remote_coverage_tools_extension")
317317
use_repo(remote_coverage_tools_extension, "remote_coverage_tools")

MODULE.bazel.lock

+14-8
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rbe_extension.bzl

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ load("@bazelci_rules//:rbe_repo.bzl", "rbe_preconfig")
2020

2121
def _bazel_rbe_deps(_ctx):
2222
rbe_preconfig(
23-
name = "rbe_ubuntu2004_java11",
24-
toolchain = "ubuntu2004-bazel-java11",
23+
name = "rbe_ubuntu2004",
24+
toolchain = "ubuntu2004",
2525
)
2626

2727
bazel_rbe_deps = module_extension(implementation = _bazel_rbe_deps)

0 commit comments

Comments
 (0)