Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Requests with multiple commits trigger merge and build for only the first commit #43

Closed
v46 opened this issue Mar 25, 2013 · 4 comments

Comments

@v46
Copy link

v46 commented Mar 25, 2013

Given a pull request that has many commits, the build is triggered when the pull request is created.

However, when the build finishes and ghprb updates github, only the first commit in the list shows a green check.

The logs show that only the first sha was used by the plugin. Why arent the remaining commits picked up?

@postalservice14
Copy link

It should be running against only the most recent commit. Is that what you mean by the first commit?

@mordonez
Copy link

Same problem here. For example I've merged the last changes from master branch into the pull requests branch and only the initial commit of the pull request it's been merged in jenkins job.

@JensTimmerman
Copy link

Same problem here, only the first commit get's tested,
I see it telling me it is doing a merge, but it is not.

e.g. https://github.com/hpcugent/vsc-passwords/pull/5

It keeps on building the first commit, tells me
GitHub pull request #5 of commit f12ae86aec6338b4eae25d324667eb6b0c9fa70e automatically merged.

however if I check the history in the workspace, it never made it in.

jenkins@jenkins1:~/workspace/generic-pr-builder$ git log f12ae86aec6338b4eae25d324667eb6b0c9fa70e
fatal: bad object f12ae86aec6338b4eae25d324667eb6b0c9fa70e

I suspect this is because the Cause.ismerged() returns True? When it should not (yet), but I can not test this atm.

@JensTimmerman
Copy link

If I ad myself as an admin it works,
but it doesn't do it for a non admin user, e.g.:
easybuilders/easybuild-framework#712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants