Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstreaming peerlog and time-to-first-byte metrics #8119

Closed
aschmahmann opened this issue May 10, 2021 · 0 comments · Fixed by #8142 or #8332
Closed

Upstreaming peerlog and time-to-first-byte metrics #8119

aschmahmann opened this issue May 10, 2021 · 0 comments · Fixed by #8142 or #8332
Assignees
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Milestone

Comments

@aschmahmann
Copy link
Contributor

There are two metrics that Protocol Labs makes use of internally that are in this (historically named) branch of go-ipfs. It'd be great to upstream these metrics given that they've proven useful so far. We'll also be able to make that branch obsolete and make our release process a bit easier.

There are currently two commits on that branch to remove:

  1. Peerlog - which logs all the peerIDs we see. We already have the peerlog plugin and we just enable it when building the Docker container in this commit.
    • If it's easy enough to make this configurable on the deployer/infrastructure side of things instead of as a commit modifying the docker build script that would be great
    • If not then we may want to consider bundling the plugin by default and triggering it via some config flag or environment variable
  2. Time-to-First-Byte - It looks like this metric is already defined but not exposed without this commit. Perhaps @lanzafame can shed some light into the background here.
@aschmahmann aschmahmann added the kind/enhancement A net-new feature or improvement to an existing feature label May 10, 2021
@BigLep BigLep added this to the go-ipfs 0.10 milestone Jul 8, 2021
@aschmahmann aschmahmann self-assigned this Jul 19, 2021
@BigLep BigLep linked a pull request Jul 27, 2021 that will close this issue
2 tasks
@guseggert guseggert reopened this Aug 5, 2021
@guseggert guseggert linked a pull request Aug 7, 2021 that will close this issue
@BigLep BigLep reopened this Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
No open projects
Archived in project
4 participants