-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starting with ipfs daemon --init
makes bunch of duplicate metrics collector registration attempted
to happen
#3913
Comments
Very strange. Did you build ipfs from source? or is this a pre-built binary? |
@whyrusleeping prebuilt, downloaded from dist.ipfs.io |
Tried master again, on OSX this time and same issue.
|
This is still a problem, same on latest win / x64 |
@hitchhiker what version of ipfs were you using? I was not able to reproduce this issue on windows 10 x64 using ipfs 0.4.10 binaries |
I can reproduce this, on latest master, Linux. |
@whyrusleeping ipfs 0.4.10 (x64) / win 10 / downloaded from https://dist.ipfs.io Steps to reproduce: Delete /users/[USERNAME]/.ipfs
�[0;37mbinding.go:74�[0m |
Ah, the issue is specifically with the |
Still an issue for me: Built with Go |
@alfiedotwtf Thanks for the bump. |
I am experiencing this issue as well in https://github.com/oduwsdl/ipwb on macOS but only when using the software (ipwb) in Docker and when the local ipfs data repo is initialized (via
go-ipfs v0.4.17 |
The issue here is that we're:
However, closing the measure datastore (the metrics one) doesn't unregister the metrics reporters. |
PR here: ipfs/go-metrics-prometheus#1 There are probably better solutions, in general, but this fixes the immediate issue (and is, in fact, the recommended approach). |
Not sure if #5413 is really a duplicate since there's not the problem on init. It only happens when you do a |
The underlying issue is still the same (we're trying to register metrics collectors multiple times instead of creating new ones). However, that does bring up a good point: we shouldn't be caching in this case anyways. See: #5414. |
(fixed) |
Version information:
Type:
Bug
Severity:
Very low
Description:
When starting a daemon with
ipfs daemon --init
, it seems that the prometheus collector is registering everything twice and printing out bunch of warnings.The text was updated successfully, but these errors were encountered: